From c33e391d267223fad8f9f6841c2729668b11da3c Mon Sep 17 00:00:00 2001 From: Michael M Date: Wed, 7 Jun 2017 15:24:29 -0700 Subject: InputConfigDiag: don't use entire ExpressionParse namespace --- Source/Core/DolphinWX/Input/InputConfigDiag.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Source/Core/DolphinWX/Input/InputConfigDiag.cpp') diff --git a/Source/Core/DolphinWX/Input/InputConfigDiag.cpp b/Source/Core/DolphinWX/Input/InputConfigDiag.cpp index 5d8bf9615e..ccf2d42f4f 100644 --- a/Source/Core/DolphinWX/Input/InputConfigDiag.cpp +++ b/Source/Core/DolphinWX/Input/InputConfigDiag.cpp @@ -70,7 +70,7 @@ #include "InputCommon/ControllerInterface/Device.h" #include "InputCommon/InputConfig.h" -using namespace ciface::ExpressionParser; +using ciface::ExpressionParser::ParseStatus; void InputConfigDialog::ConfigExtension(wxCommandEvent& event) { -- cgit v1.2.3 From 85301e2baeda9a97c4c5ebbf07807566831e22d1 Mon Sep 17 00:00:00 2001 From: Michael M Date: Wed, 7 Jun 2017 16:03:36 -0700 Subject: ParseStatus: replace NoDevice with EmptyExpression --- Source/Core/DolphinWX/Input/InputConfigDiag.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'Source/Core/DolphinWX/Input/InputConfigDiag.cpp') diff --git a/Source/Core/DolphinWX/Input/InputConfigDiag.cpp b/Source/Core/DolphinWX/Input/InputConfigDiag.cpp index ccf2d42f4f..a8c70c3ee6 100644 --- a/Source/Core/DolphinWX/Input/InputConfigDiag.cpp +++ b/Source/Core/DolphinWX/Input/InputConfigDiag.cpp @@ -347,11 +347,12 @@ void ControlDialog::UpdateGUI() case ParseStatus::SyntaxError: m_error_label->SetLabel(_("Syntax error")); break; - case ParseStatus::NoDevice: - m_error_label->SetLabel(_("Device not found")); + case ParseStatus::Successful: + m_error_label->SetLabel(control_reference->BoundCount() > 0 ? "" : _("Device not found")); break; - default: + case ParseStatus::EmptyExpression: m_error_label->SetLabel(""); + break; } }; @@ -408,7 +409,7 @@ bool ControlDialog::Validate() UpdateGUI(); const auto parse_status = control_reference->GetParseStatus(); - return parse_status == ParseStatus::Successful || parse_status == ParseStatus::NoDevice; + return parse_status == ParseStatus::Successful || parse_status == ParseStatus::EmptyExpression; } void InputConfigDialog::SetDevice(wxCommandEvent&) -- cgit v1.2.3 From 31f1c062264fcf8628e3a13c44de893d4bac0aa0 Mon Sep 17 00:00:00 2001 From: Michael M Date: Wed, 7 Jun 2017 19:02:16 -0700 Subject: ControlReference: don't reparse expression when references are updated --- Source/Core/DolphinWX/Input/InputConfigDiag.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'Source/Core/DolphinWX/Input/InputConfigDiag.cpp') diff --git a/Source/Core/DolphinWX/Input/InputConfigDiag.cpp b/Source/Core/DolphinWX/Input/InputConfigDiag.cpp index a8c70c3ee6..1e6cba569d 100644 --- a/Source/Core/DolphinWX/Input/InputConfigDiag.cpp +++ b/Source/Core/DolphinWX/Input/InputConfigDiag.cpp @@ -243,7 +243,7 @@ ControlButton::ControlButton(wxWindow* const parent, ControlReference* const _re m_configured_width(FromDIP(width)) { if (label.empty()) - SetLabelText(StrToWxStr(_ref->expression)); + SetLabelText(StrToWxStr(_ref->GetExpression())); else SetLabel(StrToWxStr(label)); } @@ -336,7 +336,7 @@ void ControlDialog::SelectControl(const std::string& name) void ControlDialog::UpdateGUI() { // update textbox - textctrl->SetValue(StrToWxStr(control_reference->expression)); + textctrl->SetValue(StrToWxStr(control_reference->GetExpression())); // updates the "bound controls:" label m_bound_label->SetLabel( @@ -365,7 +365,7 @@ void InputConfigDialog::UpdateGUI() { for (ControlButton* button : cgBox->control_buttons) { - button->SetLabelText(StrToWxStr(button->control_reference->expression)); + button->SetLabelText(StrToWxStr(button->control_reference->GetExpression())); } for (PadSetting* padSetting : cgBox->options) @@ -400,7 +400,7 @@ void InputConfigDialog::LoadDefaults(wxCommandEvent&) bool ControlDialog::Validate() { - control_reference->expression = WxStrToStr(textctrl->GetValue()); + control_reference->SetExpression(WxStrToStr(textctrl->GetValue())); const auto lock = ControllerEmu::EmulatedController::GetStateLock(); control_reference->UpdateReference(g_controller_interface, @@ -439,7 +439,7 @@ void ControlDialog::SetDevice(wxCommandEvent&) void ControlDialog::ClearControl(wxCommandEvent&) { - control_reference->expression.clear(); + control_reference->SetExpression(""); const auto lock = ControllerEmu::EmulatedController::GetStateLock(); control_reference->UpdateReference(g_controller_interface, @@ -498,7 +498,7 @@ void ControlDialog::SetSelectedControl(wxCommandEvent&) return; textctrl->WriteText(expr); - control_reference->expression = textctrl->GetValue(); + control_reference->SetExpression(WxStrToStr(textctrl->GetValue())); const auto lock = ControllerEmu::EmulatedController::GetStateLock(); control_reference->UpdateReference(g_controller_interface, @@ -534,7 +534,7 @@ void ControlDialog::AppendControl(wxCommandEvent& event) } textctrl->WriteText(expr); - control_reference->expression = textctrl->GetValue(); + control_reference->SetExpression(WxStrToStr(textctrl->GetValue())); const auto lock = ControllerEmu::EmulatedController::GetStateLock(); control_reference->UpdateReference(g_controller_interface, @@ -638,7 +638,7 @@ void InputConfigDialog::ConfigControl(wxEvent& event) void InputConfigDialog::ClearControl(wxEvent& event) { ControlButton* const btn = (ControlButton*)event.GetEventObject(); - btn->control_reference->expression.clear(); + btn->control_reference->SetExpression(""); btn->control_reference->range = 1.0; controller->UpdateReferences(g_controller_interface); @@ -717,7 +717,7 @@ bool InputConfigDialog::DetectButton(ControlButton* button) wxString control_name = ctrl->GetName(); wxString expr; GetExpressionForControl(expr, control_name); - button->control_reference->expression = expr; + button->control_reference->SetExpression(WxStrToStr(expr)); const auto lock = ControllerEmu::EmulatedController::GetStateLock(); button->control_reference->UpdateReference(g_controller_interface, controller->default_device); -- cgit v1.2.3