From 0ed31181411a9aa98dc194c6179681e670f186cb Mon Sep 17 00:00:00 2001 From: JosJuice Date: Thu, 4 Jun 2015 16:26:36 +0200 Subject: Volume: Return volume type as an enum ISOFile and GameFile were using IsWiiDisc() and IsWadFile() to set an enum value. The volume might as well return an enum directly. I increased the Qt CACHE_REVISION because m_platform now is saved as u32 instead of int, but increasing the wx CACHE_REVISION is not necessary. --- Source/Core/DolphinWX/MainAndroid.cpp | 44 ++++++++++++----------------------- 1 file changed, 15 insertions(+), 29 deletions(-) (limited to 'Source/Core/DolphinWX/MainAndroid.cpp') diff --git a/Source/Core/DolphinWX/MainAndroid.cpp b/Source/Core/DolphinWX/MainAndroid.cpp index 95b816c50b..07532be838 100644 --- a/Source/Core/DolphinWX/MainAndroid.cpp +++ b/Source/Core/DolphinWX/MainAndroid.cpp @@ -182,25 +182,17 @@ static int GetPlatform(std::string filename) if (pVolume != nullptr) { - bool is_wii_disc = pVolume->IsWiiDisc(); - bool is_wii_wad = pVolume->IsWadFile(); - - if (is_wii_disc) - { - __android_log_print(ANDROID_LOG_INFO, DOLPHIN_TAG, "Volume is a Wii disc."); - - // See Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/model/Game.java - return 1; - } - else if (is_wii_wad) - { - __android_log_print(ANDROID_LOG_INFO, DOLPHIN_TAG, "Volume is a Wii WAD."); - return 2; - } - else + switch (pVolume->GetVolumeType()) { - __android_log_print(ANDROID_LOG_INFO, DOLPHIN_TAG, "Volume is a Gamecube disc."); - return 0; + case DiscIO::IVolume::GAMECUBE_DISC: + __android_log_print(ANDROID_LOG_INFO, DOLPHIN_TAG, "Volume is a GameCube disc."); + return 0; + case DiscIO::IVolume::WII_DISC: + __android_log_print(ANDROID_LOG_INFO, DOLPHIN_TAG, "Volume is a Wii disc."); + return 1; + case DiscIO::IVolume::WII_WAD: + __android_log_print(ANDROID_LOG_INFO, DOLPHIN_TAG, "Volume is a Wii WAD."); + return 2; } } @@ -216,13 +208,9 @@ static std::string GetTitle(std::string filename) if (pVolume != nullptr) { std::map titles = pVolume->GetNames(); - - /*bool is_wii_title = IsWiiTitle(filename); - - DiscIO::IVolume::ELanguage language = SConfig::GetInstance().m_LocalCoreStartupParameter.GetCurrentLanguage( - is_wii_title); - - + /* + bool is_wii_title = pVolume->GetVolumeType() != DiscIO::IVolume::GAMECUBE_DISC; + DiscIO::IVolume::ELanguage language = SConfig::GetInstance().m_LocalCoreStartupParameter.GetCurrentLanguage(is_wii_title); auto it = titles.find(language); if (it != end) @@ -262,10 +250,8 @@ static std::string GetDescription(std::string filename) std::map descriptions = pVolume->GetDescriptions(); /* - bool is_wii_title = IsWiiTitle(filename); - - DiscIO::IVolume::ELanguage language = SConfig::GetInstance().m_LocalCoreStartupParameter.GetCurrentLanguage( - is_wii_title); + bool is_wii_title = pVolume->GetVolumeType() != DiscIO::IVolume::GAMECUBE_DISC; + DiscIO::IVolume::ELanguage language = SConfig::GetInstance().m_LocalCoreStartupParameter.GetCurrentLanguage(is_wii_title); auto it = descriptions.find(language); if (it != end) -- cgit v1.2.3