From ea71a76ea965d03ccc600ce070a58b9c335fe63f Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 12 Dec 2023 13:50:44 -0500 Subject: ExpressionParser: Pass control qualifiers by const reference These aren't necessarily cheap to copy, since a control qualifier will have around 3 std::strings inside of it, so passing by value can churn allocations a little bit. --- Source/Core/InputCommon/ControlReference/ExpressionParser.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'Source/Core/InputCommon/ControlReference/ExpressionParser.h') diff --git a/Source/Core/InputCommon/ControlReference/ExpressionParser.h b/Source/Core/InputCommon/ControlReference/ExpressionParser.h index 405445b8a0..bc39762127 100644 --- a/Source/Core/InputCommon/ControlReference/ExpressionParser.h +++ b/Source/Core/InputCommon/ControlReference/ExpressionParser.h @@ -150,9 +150,9 @@ public: { } - std::shared_ptr FindDevice(ControlQualifier qualifier) const; - Core::Device::Input* FindInput(ControlQualifier qualifier) const; - Core::Device::Output* FindOutput(ControlQualifier qualifier) const; + std::shared_ptr FindDevice(const ControlQualifier& qualifier) const; + Core::Device::Input* FindInput(const ControlQualifier& qualifier) const; + Core::Device::Output* FindOutput(const ControlQualifier& qualifier) const; // Returns an existing variable by the specified name if already existing. Creates it otherwise. std::shared_ptr GetVariablePtr(const std::string& name); -- cgit v1.2.3