From 95dec132030e72b74da6bc46966e4fe5e4e239c0 Mon Sep 17 00:00:00 2001 From: Martino Fontana Date: Mon, 6 Apr 2026 11:37:26 +0200 Subject: Improve usage of std::move and const references parameters Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`. Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move. Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible. --- Source/Core/InputCommon/ControllerEmu/ControlGroup/Buttons.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'Source/Core/InputCommon/ControllerEmu/ControlGroup/Buttons.cpp') diff --git a/Source/Core/InputCommon/ControllerEmu/ControlGroup/Buttons.cpp b/Source/Core/InputCommon/ControllerEmu/ControlGroup/Buttons.cpp index 612310a470..65926a2524 100644 --- a/Source/Core/InputCommon/ControllerEmu/ControlGroup/Buttons.cpp +++ b/Source/Core/InputCommon/ControllerEmu/ControlGroup/Buttons.cpp @@ -4,6 +4,7 @@ #include "InputCommon/ControllerEmu/ControlGroup/Buttons.h" #include +#include namespace ControllerEmu { @@ -11,8 +12,8 @@ Buttons::Buttons(const std::string& name_) : Buttons(name_, name_) { } -Buttons::Buttons(const std::string& ini_name, const std::string& group_name) - : ControlGroup(ini_name, group_name, GroupType::Buttons) +Buttons::Buttons(std::string ini_name, std::string group_name) + : ControlGroup(std::move(ini_name), std::move(group_name), GroupType::Buttons) { } -- cgit v1.2.3