From ca6d8e1f0b1b17096a9e09c61e8d7e1eb97ab06f Mon Sep 17 00:00:00 2001 From: Jordan Woyak Date: Tue, 4 Nov 2025 14:36:46 -0600 Subject: InputCommon: Make ControllerInterface RegisterDevicesChangedCallback use Common::HookableEvent. --- .../ControllerInterface/ControllerInterface.h | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) (limited to 'Source/Core/InputCommon/ControllerInterface/ControllerInterface.h') diff --git a/Source/Core/InputCommon/ControllerInterface/ControllerInterface.h b/Source/Core/InputCommon/ControllerInterface/ControllerInterface.h index e5712f0a4f..806c6b4b2a 100644 --- a/Source/Core/InputCommon/ControllerInterface/ControllerInterface.h +++ b/Source/Core/InputCommon/ControllerInterface/ControllerInterface.h @@ -5,12 +5,13 @@ #include #include -#include #include #include +#include "Common/HookableEvent.h" #include "Common/Matrix.h" #include "Common/WindowSystemInfo.h" + #include "InputCommon/ControllerInterface/CoreDevice.h" #include "InputCommon/ControllerInterface/InputBackend.h" @@ -64,8 +65,6 @@ enum class InputChannel class ControllerInterface : public ciface::Core::DeviceContainer { public: - using HotplugCallbackHandle = std::list>::iterator; - enum class WindowChangeReason { // Application is shutting down @@ -115,9 +114,9 @@ public: bool IsMouseCenteringRequested() const; - HotplugCallbackHandle RegisterDevicesChangedCallback(std::function callback); - void UnregisterDevicesChangedCallback(const HotplugCallbackHandle& handle); - void InvokeDevicesChangedCallbacks() const; + [[nodiscard]] Common::EventHook + RegisterDevicesChangedCallback(std::string_view name, + Common::HookableEvent<>::CallbackType callback); static void SetCurrentInputChannel(ciface::InputChannel); static ciface::InputChannel GetCurrentInputChannel(); @@ -127,9 +126,11 @@ public: private: void ClearDevices(); - std::list> m_devices_changed_callbacks; + void InvokeDevicesChangedCallbacks(); + + Common::HookableEvent<> m_devices_changed_event{"Devices Changed"}; + mutable std::recursive_mutex m_devices_population_mutex; - mutable std::mutex m_callbacks_mutex; std::atomic m_is_init; // This is now always protected by m_devices_population_mutex, so // it doesn't really need to be a counter or atomic anymore (it could be a raw bool), -- cgit v1.2.3