From 25aca8cc4a7bfa764d1381dd57fd6e75d7039c26 Mon Sep 17 00:00:00 2001 From: Jordan Woyak Date: Tue, 22 Jun 2010 08:30:33 +0000 Subject: GCPad/New Wiimote: Fixed issue 2848 (profiles not saving). Renamed DInput mouse axes to "Axis [XYZ][-+]" from "Mouse XYZ...". Minor cleanup/warning removal. git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@5767 8ced0084-cf51-0410-be5f-012b33b47a6e --- .../ControllerInterface/ControllerInterface.cpp | 42 +++++++++------------- 1 file changed, 16 insertions(+), 26 deletions(-) (limited to 'Source/Core/InputCommon/Src/ControllerInterface/ControllerInterface.cpp') diff --git a/Source/Core/InputCommon/Src/ControllerInterface/ControllerInterface.cpp b/Source/Core/InputCommon/Src/ControllerInterface/ControllerInterface.cpp index 88571b5a41..2888465487 100644 --- a/Source/Core/InputCommon/Src/ControllerInterface/ControllerInterface.cpp +++ b/Source/Core/InputCommon/Src/ControllerInterface/ControllerInterface.cpp @@ -327,11 +327,11 @@ void ControllerInterface::DeviceQualifier::FromDevice(const ControllerInterface: source= dev->GetSource(); } -bool ControllerInterface::Device::operator==(const ControllerInterface::DeviceQualifier& devq) const +bool ControllerInterface::DeviceQualifier::operator==(const ControllerInterface::Device* const dev) const { - if (GetId() == devq.cid) - if (GetName() == devq.name) - if (GetSource() == devq.source) + if (dev->GetId() == cid) + if (dev->GetName() == name) + if (dev->GetSource() == source) return true; return false; } @@ -390,11 +390,7 @@ void ControllerInterface::UpdateReference(ControllerInterface::ControlReference* devq.FromString(dev_str); // find device - std::vector::const_iterator di = FindDevice(m_devices, devq); - - - if (m_devices.end() != di) - devc.device = *di; + devc.device = FindDevice(devq); if (devc.device) { @@ -407,10 +403,9 @@ void ControllerInterface::UpdateReference(ControllerInterface::ControlReference* // FIXME: Use std::find instead of a for loop // i = std::find(devc.device->Inputs().begin(), devc.device->Inputs().end(), ctrl_str); - for(i = devc.device->Inputs().begin(); i < devc.device->Inputs().end(); ++i) { + for(i = devc.device->Inputs().begin(); i < devc.device->Inputs().end(); ++i) if(*(*i) == ctrl_str) break; - } if (devc.device->Inputs().end() != i) { @@ -424,11 +419,9 @@ void ControllerInterface::UpdateReference(ControllerInterface::ControlReference* // FIXME: Use std::find instead of a for loop // i = std::find(devc.device->Outputs().begin(), devc.device->Outputs().end(), ctrl_str); - for(i = devc.device->Outputs().begin(); i < devc.device->Outputs().end(); ++i) { + for(i = devc.device->Outputs().begin(); i < devc.device->Outputs().end(); ++i) if(*(*i) == ctrl_str) break; - } - if (devc.device->Outputs().end() != i) { @@ -455,19 +448,16 @@ void ControllerInterface::UpdateReference(ControllerInterface::ControlReference* } } -std::vector::const_iterator FindDevice( - const std::vector& devices, const ControllerInterface::DeviceQualifier& devq) { - - std::vector::const_iterator di; - - // FIXME: Use std::find instead of a for loop - // di = std::find(m_devices.begin(), m_devices.end(), devq); - for(di = devices.begin(); di < devices.end(); ++di) { - if(*(*di) == devq) - break; - } +ControllerInterface::Device* ControllerInterface::FindDevice(const ControllerInterface::DeviceQualifier& devq) const +{ + std::vector::const_iterator + di = m_devices.begin(), + de = m_devices.end(); + for (; di!=de; ++di) + if (devq == *di) + return *di; - return di; + return NULL; } // -- cgit v1.2.3