From ffaa9a3bea56bd8e82e32e187fd9dbe6ffa00993 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Sat, 19 Aug 2017 11:08:09 -0400 Subject: SW NativeVertexFormat: Utilize std::array where applicable Gets rid of some hardcoded looping bounds, and also simplifies code in some places, sometimes allowing for removal of a loop altogether. --- Source/Core/VideoBackends/Software/Clipper.cpp | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) (limited to 'Source/Core/VideoBackends/Software/Clipper.cpp') diff --git a/Source/Core/VideoBackends/Software/Clipper.cpp b/Source/Core/VideoBackends/Software/Clipper.cpp index 764247bdaf..58242c09f9 100644 --- a/Source/Core/VideoBackends/Software/Clipper.cpp +++ b/Source/Core/VideoBackends/Software/Clipper.cpp @@ -338,15 +338,11 @@ static void CopyVertex(OutputVertexData* dst, const OutputVertexData* src, float dst->screenPosition.y = src->screenPosition.y + dy; dst->screenPosition.z = src->screenPosition.z; - for (int i = 0; i < 3; ++i) - dst->normal[i] = src->normal[i]; - - for (int i = 0; i < 4; ++i) - dst->color[0][i] = src->color[0][i]; + dst->normal = src->normal; + dst->color[0] = src->color[0]; // todo - s offset - for (int i = 0; i < 8; ++i) - dst->texCoords[i] = src->texCoords[i]; + dst->texCoords = src->texCoords; } void ProcessLine(OutputVertexData* lineV0, OutputVertexData* lineV1) -- cgit v1.2.3 From bc57ab39231b9a6d9b5f1c31b520cdee9716d6df Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 22 Aug 2017 22:45:25 -0400 Subject: Clipper: Copy both color sequences in CopyVertex as opposed to one This is likely an oversight. --- Source/Core/VideoBackends/Software/Clipper.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Source/Core/VideoBackends/Software/Clipper.cpp') diff --git a/Source/Core/VideoBackends/Software/Clipper.cpp b/Source/Core/VideoBackends/Software/Clipper.cpp index 58242c09f9..f527156a27 100644 --- a/Source/Core/VideoBackends/Software/Clipper.cpp +++ b/Source/Core/VideoBackends/Software/Clipper.cpp @@ -339,7 +339,7 @@ static void CopyVertex(OutputVertexData* dst, const OutputVertexData* src, float dst->screenPosition.z = src->screenPosition.z; dst->normal = src->normal; - dst->color[0] = src->color[0]; + dst->color = src->color; // todo - s offset dst->texCoords = src->texCoords; -- cgit v1.2.3