From e825af7b1b673bc265e3c865eca4b5b35297a9bc Mon Sep 17 00:00:00 2001 From: Pokechu22 Date: Sun, 3 Jan 2021 23:22:48 -0800 Subject: Software: Remove normalization special case The special case doesn't appear to make a significant difference in any games, and the current implementation has a (minor, fixable) issue that breaks Super Mario Sunshine (both with a failed assertion (https://bugs.dolphin-emu.org/issues/11742) and a rendering issue (https://bugs.dolphin-emu.org/issues/7476)). Hardware testing wasn't able to reproduce the special case, either, so it may just not exist. PR #9315 contains a fixed implementation of the special case on all video backends, and can serve as a basis for it being reintroduced if it is found to exist under more specific circumstances. For now, I don't see a reason to keep it present. --- Source/Core/VideoBackends/Software/TransformUnit.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Source/Core/VideoBackends/Software/TransformUnit.h') diff --git a/Source/Core/VideoBackends/Software/TransformUnit.h b/Source/Core/VideoBackends/Software/TransformUnit.h index 41f8645b3a..986904fc6a 100644 --- a/Source/Core/VideoBackends/Software/TransformUnit.h +++ b/Source/Core/VideoBackends/Software/TransformUnit.h @@ -12,5 +12,5 @@ namespace TransformUnit void TransformPosition(const InputVertexData* src, OutputVertexData* dst); void TransformNormal(const InputVertexData* src, bool nbt, OutputVertexData* dst); void TransformColor(const InputVertexData* src, OutputVertexData* dst); -void TransformTexCoord(const InputVertexData* src, OutputVertexData* dst, bool specialCase); +void TransformTexCoord(const InputVertexData* src, OutputVertexData* dst); } // namespace TransformUnit -- cgit v1.2.3