From b5654a2464b02dc0bc8177d75db24236923e6ad2 Mon Sep 17 00:00:00 2001 From: comex Date: Thu, 27 Mar 2014 23:52:27 -0400 Subject: Don't cast -1 to enum to represent a missing value. This is undefined behavior in C++, and a clang warning suggests it is actually producing bad code as a result: ../Source/Core/VideoCommon/BPFunctions.cpp:164:45: warning: comparison of constant 4294967295 with expression of type 'PEControl::PixelFormat' is always false [-Wtautological-constant-out-of-range-compare] if (new_format == old_format || old_format == (unsigned int)-1) --- Source/Core/VideoCommon/BPFunctions.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Source/Core/VideoCommon/BPFunctions.cpp') diff --git a/Source/Core/VideoCommon/BPFunctions.cpp b/Source/Core/VideoCommon/BPFunctions.cpp index 58362f1a57..9bc9b4d3dd 100644 --- a/Source/Core/VideoCommon/BPFunctions.cpp +++ b/Source/Core/VideoCommon/BPFunctions.cpp @@ -161,7 +161,7 @@ void OnPixelFormatChange() auto new_format = bpmem.zcontrol.pixel_format; // no need to reinterpret pixel data in these cases - if (new_format == old_format || old_format == (unsigned int)-1) + if (new_format == old_format || old_format == PEControl::INVALID_FMT) goto skip; // Check for pixel format changes -- cgit v1.2.3