From cc331feb020d71f109d41b7f841bd69caa96bbb3 Mon Sep 17 00:00:00 2001 From: Jordan Woyak Date: Mon, 27 Oct 2025 18:14:57 -0500 Subject: VideoCommon: Make Presenter aware of the next swap time to eliminate unsafe usage of GetTicks() with ImmediateXFB + DualCore. --- Source/Core/VideoCommon/BPStructs.cpp | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) (limited to 'Source/Core/VideoCommon/BPStructs.cpp') diff --git a/Source/Core/VideoCommon/BPStructs.cpp b/Source/Core/VideoCommon/BPStructs.cpp index 1ece9f278e..9518fd0446 100644 --- a/Source/Core/VideoCommon/BPStructs.cpp +++ b/Source/Core/VideoCommon/BPStructs.cpp @@ -13,7 +13,6 @@ #include "Common/EnumMap.h" #include "Common/Logging/Log.h" -#include "Core/CoreTiming.h" #include "Core/DolphinAnalytics.h" #include "Core/FifoPlayer/FifoPlayer.h" #include "Core/FifoPlayer/FifoRecorder.h" @@ -359,14 +358,8 @@ static void BPWritten(PixelShaderManager& pixel_shader_manager, XFStateManager& if (g_ActiveConfig.bImmediateXFB) { - // TODO: GetTicks is not sane from the GPU thread. - // This value is currently used for frame dumping and the custom shader "time_ms" value. - // Frame dumping has more calls that aren't sane from the GPU thread. - // i.e. Frame dumping is not sane in "Dual Core" mode in general. - const u64 ticks = system.GetCoreTiming().GetTicks(); - // below div two to convert from bytes to pixels - it expects width, not stride - g_presenter->ImmediateSwap(destAddr, destStride / 2, destStride, height, ticks); + g_presenter->ImmediateSwap(destAddr, destStride / 2, destStride, height); } else { -- cgit v1.2.3