From 0327b11e0bec1b591c2a6f7e688be8e30170c1bd Mon Sep 17 00:00:00 2001 From: Lioncash Date: Wed, 24 Jan 2024 22:40:03 -0500 Subject: GraphicsModGroup: Reduce object churn We can emplace and move to avoid doing object copies. --- Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h') diff --git a/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h b/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h index 721c8e5c2c..fb24798517 100644 --- a/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h +++ b/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h @@ -16,7 +16,7 @@ struct GraphicsModConfig; class GraphicsModGroupConfig { public: - explicit GraphicsModGroupConfig(const std::string& game_id); + explicit GraphicsModGroupConfig(std::string game_id); ~GraphicsModGroupConfig(); GraphicsModGroupConfig(const GraphicsModGroupConfig&); -- cgit v1.2.3 From 2253d9a95d5c07524ecb9cf8711166e183347e41 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Wed, 24 Jan 2024 22:41:28 -0500 Subject: GraphicsModGroup: Mark move constructor and assignment as noexcept Allows containers to optimize off of std::move_if_noexcept --- Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h') diff --git a/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h b/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h index fb24798517..9614951e96 100644 --- a/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h +++ b/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h @@ -20,10 +20,10 @@ public: ~GraphicsModGroupConfig(); GraphicsModGroupConfig(const GraphicsModGroupConfig&); - GraphicsModGroupConfig(GraphicsModGroupConfig&&); + GraphicsModGroupConfig(GraphicsModGroupConfig&&) noexcept; GraphicsModGroupConfig& operator=(const GraphicsModGroupConfig&); - GraphicsModGroupConfig& operator=(GraphicsModGroupConfig&&); + GraphicsModGroupConfig& operator=(GraphicsModGroupConfig&&) noexcept; void Load(); void Save() const; -- cgit v1.2.3