From bc360584a3a8a8902f50642496b2d1287e5088ac Mon Sep 17 00:00:00 2001 From: iwubcode Date: Sat, 2 Jul 2022 14:49:51 -0500 Subject: VideoCommon: add structures to graphics mods to allow for future adding or removing parameters with less code overhead --- .../GraphicsModSystem/Runtime/Actions/MoveAction.cpp | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) (limited to 'Source/Core/VideoCommon/GraphicsModSystem/Runtime/Actions/MoveAction.cpp') diff --git a/Source/Core/VideoCommon/GraphicsModSystem/Runtime/Actions/MoveAction.cpp b/Source/Core/VideoCommon/GraphicsModSystem/Runtime/Actions/MoveAction.cpp index cc724c0480..d141af585c 100644 --- a/Source/Core/VideoCommon/GraphicsModSystem/Runtime/Actions/MoveAction.cpp +++ b/Source/Core/VideoCommon/GraphicsModSystem/Runtime/Actions/MoveAction.cpp @@ -30,18 +30,26 @@ MoveAction::MoveAction(Common::Vec3 position_offset) : m_position_offset(positio { } -void MoveAction::OnProjection(Common::Matrix44* matrix) +void MoveAction::OnProjection(GraphicsModActionData::Projection* projection) { - if (!matrix) + if (!projection) [[unlikely]] return; - *matrix *= Common::Matrix44::Translate(m_position_offset); + if (!projection->matrix) [[unlikely]] + return; + + auto& matrix = *projection->matrix; + matrix = matrix * Common::Matrix44::Translate(m_position_offset); } -void MoveAction::OnProjectionAndTexture(Common::Matrix44* matrix) +void MoveAction::OnProjectionAndTexture(GraphicsModActionData::Projection* projection) { - if (!matrix) + if (!projection) [[unlikely]] + return; + + if (!projection->matrix) [[unlikely]] return; - *matrix *= Common::Matrix44::Translate(m_position_offset); + auto& matrix = *projection->matrix; + matrix = matrix * Common::Matrix44::Translate(m_position_offset); } -- cgit v1.2.3