From a14c88ba67a51b0a563a5fc800cd089e82ffacaf Mon Sep 17 00:00:00 2001 From: Martino Fontana Date: Fri, 23 Jan 2026 21:30:01 +0100 Subject: Remove unused imports Yellow squiggly lines begone! Done automatically on .cpp files through `run-clang-tidy`, with manual corrections to the mistakes. If an import is directly used, but is technically unnecessary since it's recursively imported by something else, it is *not* removed. The tool doesn't touch .h files, so I did some of them by hand while fixing errors due to old recursive imports. Not everything is removed, but the cleanup should be substantial enough. Because this done on Linux, code that isn't used on it is mostly untouched. (Hopefully no open PR is depending on these imports...) --- .../VideoCommon/GraphicsModSystem/Config/GraphicsMod.cpp | 1 - .../GraphicsModSystem/Config/GraphicsModGroup.cpp | 4 +--- .../Runtime/Actions/CustomPipelineAction.cpp | 15 --------------- .../GraphicsModSystem/Runtime/CustomShaderCache.cpp | 1 + .../GraphicsModSystem/Runtime/CustomShaderCache.h | 6 ++---- .../GraphicsModSystem/Runtime/GraphicsModActionData.h | 3 +-- .../GraphicsModSystem/Runtime/GraphicsModManager.cpp | 2 +- .../GraphicsModSystem/Runtime/GraphicsModManager.h | 4 ++-- 8 files changed, 8 insertions(+), 28 deletions(-) (limited to 'Source/Core/VideoCommon/GraphicsModSystem') diff --git a/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsMod.cpp b/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsMod.cpp index ef71ba6eb8..c8fe390e4c 100644 --- a/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsMod.cpp +++ b/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsMod.cpp @@ -5,7 +5,6 @@ #include -#include "Common/CommonPaths.h" #include "Common/FileUtil.h" #include "Common/JsonUtil.h" #include "Common/Logging/Log.h" diff --git a/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.cpp b/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.cpp index 3c234e9ec1..e3cf5b9a10 100644 --- a/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.cpp +++ b/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.cpp @@ -3,19 +3,17 @@ #include "VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h" +#include #include -#include #include #include #include "Common/CommonPaths.h" -#include "Common/FileSearch.h" #include "Common/FileUtil.h" #include "Common/JsonUtil.h" #include "Common/Logging/Log.h" #include "Common/StringUtil.h" -#include "Core/ConfigManager.h" #include "VideoCommon/GraphicsModSystem/Config/GraphicsMod.h" #include "VideoCommon/GraphicsModSystem/Constants.h" diff --git a/Source/Core/VideoCommon/GraphicsModSystem/Runtime/Actions/CustomPipelineAction.cpp b/Source/Core/VideoCommon/GraphicsModSystem/Runtime/Actions/CustomPipelineAction.cpp index 7366ad7ff7..4e22d5b3f8 100644 --- a/Source/Core/VideoCommon/GraphicsModSystem/Runtime/Actions/CustomPipelineAction.cpp +++ b/Source/Core/VideoCommon/GraphicsModSystem/Runtime/Actions/CustomPipelineAction.cpp @@ -3,22 +3,7 @@ #include "VideoCommon/GraphicsModSystem/Runtime/Actions/CustomPipelineAction.h" -#include -#include -#include - -#include - -#include "Common/FileUtil.h" #include "Common/Logging/Log.h" -#include "Common/StringUtil.h" -#include "Common/VariantUtil.h" -#include "Core/System.h" - -#include "VideoCommon/AbstractGfx.h" -#include "VideoCommon/Assets/DirectFilesystemAssetLibrary.h" -#include "VideoCommon/ShaderGenCommon.h" -#include "VideoCommon/TextureCacheBase.h" std::unique_ptr CustomPipelineAction::Create(std::shared_ptr library) diff --git a/Source/Core/VideoCommon/GraphicsModSystem/Runtime/CustomShaderCache.cpp b/Source/Core/VideoCommon/GraphicsModSystem/Runtime/CustomShaderCache.cpp index 0c4cf43227..54b0d786f2 100644 --- a/Source/Core/VideoCommon/GraphicsModSystem/Runtime/CustomShaderCache.cpp +++ b/Source/Core/VideoCommon/GraphicsModSystem/Runtime/CustomShaderCache.cpp @@ -5,6 +5,7 @@ #include "VideoCommon/AbstractGfx.h" #include "VideoCommon/VideoConfig.h" +#include "VideoCommon/VideoEvents.h" CustomShaderCache::CustomShaderCache() { diff --git a/Source/Core/VideoCommon/GraphicsModSystem/Runtime/CustomShaderCache.h b/Source/Core/VideoCommon/GraphicsModSystem/Runtime/CustomShaderCache.h index ff2aba2823..7890cafeb6 100644 --- a/Source/Core/VideoCommon/GraphicsModSystem/Runtime/CustomShaderCache.h +++ b/Source/Core/VideoCommon/GraphicsModSystem/Runtime/CustomShaderCache.h @@ -3,13 +3,12 @@ #pragma once -#include #include #include #include #include -#include -#include + +#include "Common/HookableEvent.h" #include "VideoCommon/AbstractPipeline.h" #include "VideoCommon/AbstractShader.h" @@ -18,7 +17,6 @@ #include "VideoCommon/PixelShaderGen.h" #include "VideoCommon/ShaderGenCommon.h" #include "VideoCommon/UberShaderPixel.h" -#include "VideoCommon/VideoEvents.h" struct CustomShaderInstance { diff --git a/Source/Core/VideoCommon/GraphicsModSystem/Runtime/GraphicsModActionData.h b/Source/Core/VideoCommon/GraphicsModSystem/Runtime/GraphicsModActionData.h index f7c12fe6e5..a4e883ffc2 100644 --- a/Source/Core/VideoCommon/GraphicsModSystem/Runtime/GraphicsModActionData.h +++ b/Source/Core/VideoCommon/GraphicsModSystem/Runtime/GraphicsModActionData.h @@ -3,7 +3,6 @@ #pragma once -#include #include #include #include @@ -13,7 +12,7 @@ #include "Common/Matrix.h" #include "Common/SmallVector.h" #include "VideoCommon/Assets/TextureAsset.h" -#include "VideoCommon/PixelShaderGen.h" +#include "VideoCommon/ShaderGenCommon.h" namespace GraphicsModActionData { diff --git a/Source/Core/VideoCommon/GraphicsModSystem/Runtime/GraphicsModManager.cpp b/Source/Core/VideoCommon/GraphicsModSystem/Runtime/GraphicsModManager.cpp index 3caaa999fd..79f19fe325 100644 --- a/Source/Core/VideoCommon/GraphicsModSystem/Runtime/GraphicsModManager.cpp +++ b/Source/Core/VideoCommon/GraphicsModSystem/Runtime/GraphicsModManager.cpp @@ -18,8 +18,8 @@ #include "VideoCommon/GraphicsModSystem/Config/GraphicsModAsset.h" #include "VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h" #include "VideoCommon/GraphicsModSystem/Runtime/GraphicsModActionFactory.h" -#include "VideoCommon/TextureInfo.h" #include "VideoCommon/VideoConfig.h" +#include "VideoCommon/VideoEvents.h" std::unique_ptr g_graphics_mod_manager; diff --git a/Source/Core/VideoCommon/GraphicsModSystem/Runtime/GraphicsModManager.h b/Source/Core/VideoCommon/GraphicsModSystem/Runtime/GraphicsModManager.h index 2d67b4db76..98c121fc5e 100644 --- a/Source/Core/VideoCommon/GraphicsModSystem/Runtime/GraphicsModManager.h +++ b/Source/Core/VideoCommon/GraphicsModSystem/Runtime/GraphicsModManager.h @@ -10,10 +10,10 @@ #include #include +#include "Common/HookableEvent.h" + #include "VideoCommon/GraphicsModSystem/Runtime/FBInfo.h" #include "VideoCommon/GraphicsModSystem/Runtime/GraphicsModAction.h" -#include "VideoCommon/TextureInfo.h" -#include "VideoCommon/VideoEvents.h" #include "VideoCommon/XFMemory.h" class GraphicsModGroupConfig; -- cgit v1.2.3