From 95dec132030e72b74da6bc46966e4fe5e4e239c0 Mon Sep 17 00:00:00 2001 From: Martino Fontana Date: Mon, 6 Apr 2026 11:37:26 +0200 Subject: Improve usage of std::move and const references parameters Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`. Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move. Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible. --- Source/Core/VideoCommon/NetPlayGolfUI.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'Source/Core/VideoCommon/NetPlayGolfUI.cpp') diff --git a/Source/Core/VideoCommon/NetPlayGolfUI.cpp b/Source/Core/VideoCommon/NetPlayGolfUI.cpp index d8ada720ad..87b866b348 100644 --- a/Source/Core/VideoCommon/NetPlayGolfUI.cpp +++ b/Source/Core/VideoCommon/NetPlayGolfUI.cpp @@ -3,6 +3,8 @@ #include "VideoCommon/NetPlayGolfUI.h" +#include + #include #include @@ -13,8 +15,8 @@ constexpr float DEFAULT_WINDOW_HEIGHT = 45.0f; std::unique_ptr g_netplay_golf_ui; -NetPlayGolfUI::NetPlayGolfUI(std::shared_ptr netplay_client) - : m_netplay_client{netplay_client} +NetPlayGolfUI::NetPlayGolfUI(std::weak_ptr netplay_client) + : m_netplay_client{std::move(netplay_client)} { } -- cgit v1.2.3