From d90537cc18df27a5e893beb767d8801131820659 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 11 Dec 2023 13:51:47 -0500 Subject: AchievementManager: Return by reference from GetLock() This makes the API a little nicer to use, since you don't need to do a mandatory dereference when passing the lock into any kind of scope guard. --- Source/Core/VideoCommon/OnScreenUI.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Source/Core/VideoCommon/OnScreenUI.cpp') diff --git a/Source/Core/VideoCommon/OnScreenUI.cpp b/Source/Core/VideoCommon/OnScreenUI.cpp index 254ff6f2bb..88141736e4 100644 --- a/Source/Core/VideoCommon/OnScreenUI.cpp +++ b/Source/Core/VideoCommon/OnScreenUI.cpp @@ -330,7 +330,7 @@ void OnScreenUI::DrawDebugText() #ifdef USE_RETRO_ACHIEVEMENTS void OnScreenUI::DrawChallenges() { - std::lock_guard lg{*AchievementManager::GetInstance().GetLock()}; + std::lock_guard lg{AchievementManager::GetInstance().GetLock()}; const auto& challenge_icons = AchievementManager::GetInstance().GetChallengeIcons(); if (challenge_icons.empty()) return; -- cgit v1.2.3