From 4b2aa948e662aa037ad39f5ee81a64256a4d61aa Mon Sep 17 00:00:00 2001 From: degasus Date: Tue, 31 Jan 2023 18:10:48 +0100 Subject: VideoBackend/OGL: Prefer KHR_subgroup over NV_shader_thread. While the NV extension is totally fine, the KHR extension should be able to support more hardware. For NVIDIA, the hardware either supports both or neither, it just needs a driver from the last two years. For AMD, the drivers from late 2022-12 seems to bring support for the KHR extension. For Intel, the KHR is also supported for some years. --- Source/Core/VideoCommon/PixelShaderGen.cpp | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) (limited to 'Source/Core/VideoCommon/PixelShaderGen.cpp') diff --git a/Source/Core/VideoCommon/PixelShaderGen.cpp b/Source/Core/VideoCommon/PixelShaderGen.cpp index df6f5dfab8..4dcd681185 100644 --- a/Source/Core/VideoCommon/PixelShaderGen.cpp +++ b/Source/Core/VideoCommon/PixelShaderGen.cpp @@ -457,15 +457,12 @@ void UpdateBoundingBox(float2 rawpos) {{ int2 pos_br = pos | 1; // round up to odd #ifdef SUPPORTS_SUBGROUP_REDUCTION - if (CAN_USE_SUBGROUP_REDUCTION) {{ - int2 min_pos = IS_HELPER_INVOCATION ? int2(2147483647, 2147483647) : pos_tl; - int2 max_pos = IS_HELPER_INVOCATION ? int2(-2147483648, -2147483648) : pos_br; - SUBGROUP_MIN(min_pos); - SUBGROUP_MAX(max_pos); + if (!IS_HELPER_INVOCATION) + {{ + SUBGROUP_MIN(pos_tl); + SUBGROUP_MAX(pos_br); if (IS_FIRST_ACTIVE_INVOCATION) - UpdateBoundingBoxBuffer(min_pos, max_pos); - }} else {{ - UpdateBoundingBoxBuffer(pos_tl, pos_br); + UpdateBoundingBoxBuffer(pos_tl, pos_br); }} #else UpdateBoundingBoxBuffer(pos_tl, pos_br); -- cgit v1.2.3