From e31d6feaa23afc00a84762300e37d2f634a659ff Mon Sep 17 00:00:00 2001 From: comex Date: Sun, 24 Aug 2014 19:13:46 -0400 Subject: Unify three types of non-FIFO requests to the GPU thread around Common::Event and Common::Flag. The only possible functionality change is that s_efbAccessRequested and s_swapRequested are no longer reset at init and shutdown of the OGL backend (only; this is the only interaction any files other than MainBase.cpp have with them). I am fairly certain this was entirely vestigial. Possible performance implications: efbAccessReady now uses an Event rather than spinning, which might be slightly slower, but considering the slow loop the flags are being checked in from the GPU thread, I doubt it's noticeable. Also, this uses sequentially consistent rather than release/acquire memory order, which might be slightly slower, especially on ARM... something to improve in Event/Flag, really. --- Source/Core/VideoCommon/RenderBase.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Source/Core/VideoCommon/RenderBase.cpp') diff --git a/Source/Core/VideoCommon/RenderBase.cpp b/Source/Core/VideoCommon/RenderBase.cpp index 07b4f8bccb..e877023293 100644 --- a/Source/Core/VideoCommon/RenderBase.cpp +++ b/Source/Core/VideoCommon/RenderBase.cpp @@ -126,7 +126,7 @@ void Renderer::RenderToXFB(u32 xfbAddr, const EFBRectangle& sourceRc, u32 fbWidt else { Swap(xfbAddr, fbWidth, fbHeight,sourceRc,Gamma); - Common::AtomicStoreRelease(s_swapRequested, false); + s_swapRequested.Clear(); } } -- cgit v1.2.3