From 2be579e8bad372e7a7433a7d6300939ecef4c654 Mon Sep 17 00:00:00 2001 From: nitsuja Date: Sun, 1 Jan 2012 12:46:02 -0800 Subject: fixed some graphics problems with loading savestates (for example, wrong colors on title screen of metroid prime 3) --- Source/Core/VideoCommon/Src/BPFunctions.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'Source/Core/VideoCommon/Src/BPFunctions.cpp') diff --git a/Source/Core/VideoCommon/Src/BPFunctions.cpp b/Source/Core/VideoCommon/Src/BPFunctions.cpp index 4f7315e832..dc0d0723a6 100644 --- a/Source/Core/VideoCommon/Src/BPFunctions.cpp +++ b/Source/Core/VideoCommon/Src/BPFunctions.cpp @@ -39,7 +39,7 @@ void FlushPipeline() VertexManager::Flush(); } -void SetGenerationMode(const BPCmd &bp) +void SetGenerationMode() { g_renderer->SetGenerationMode(); } @@ -64,30 +64,30 @@ void SetScissor() g_renderer->SetScissorRect(trc); } -void SetLineWidth(const BPCmd &bp) +void SetLineWidth() { g_renderer->SetLineWidth(); } -void SetDepthMode(const BPCmd &bp) +void SetDepthMode() { g_renderer->SetDepthMode(); } -void SetBlendMode(const BPCmd &bp) +void SetBlendMode() { g_renderer->SetBlendMode(false); } -void SetDitherMode(const BPCmd &bp) +void SetDitherMode() { g_renderer->SetDitherMode(); } -void SetLogicOpMode(const BPCmd &bp) +void SetLogicOpMode() { g_renderer->SetLogicOpMode(); } -void SetColorMask(const BPCmd &bp) +void SetColorMask() { g_renderer->SetColorMask(); } @@ -119,7 +119,7 @@ void CopyEFB(u32 dstAddr, unsigned int dstFormat, unsigned int srcFormat, - convert the RGBA8 color to RGBA6/RGB8/RGB565 and convert it to RGBA8 again - convert the Z24 depth value to Z16 and back to Z24 */ -void ClearScreen(const BPCmd &bp, const EFBRectangle &rc) +void ClearScreen(const EFBRectangle &rc) { bool colorEnable = bpmem.blendmode.colorupdate; bool alphaEnable = bpmem.blendmode.alphaupdate; @@ -152,7 +152,7 @@ void ClearScreen(const BPCmd &bp, const EFBRectangle &rc) } } -void OnPixelFormatChange(const BPCmd &bp) +void OnPixelFormatChange() { int convtype = -1; -- cgit v1.2.3 From bfde41895f52402874359e70c495ca79c8c501c6 Mon Sep 17 00:00:00 2001 From: Pierre Bourdon Date: Sun, 27 May 2012 08:03:26 +0200 Subject: Update the viewport when the scissor offset is changed Fixes a bug with Another Code: R that was noticed when gx-optimization was merged. --- Source/Core/VideoCommon/Src/BPFunctions.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'Source/Core/VideoCommon/Src/BPFunctions.cpp') diff --git a/Source/Core/VideoCommon/Src/BPFunctions.cpp b/Source/Core/VideoCommon/Src/BPFunctions.cpp index dc0d0723a6..cddeae3000 100644 --- a/Source/Core/VideoCommon/Src/BPFunctions.cpp +++ b/Source/Core/VideoCommon/Src/BPFunctions.cpp @@ -62,6 +62,8 @@ void SetScissor() TargetRectangle trc = g_renderer->ConvertEFBRectangle(rc); g_renderer->SetScissorRect(trc); + + UpdateViewportWithCorrection(); } void SetLineWidth() -- cgit v1.2.3 From 8b62be20253a282edc8308cd3ce541be5ecbbb70 Mon Sep 17 00:00:00 2001 From: degasus Date: Fri, 7 Dec 2012 22:49:18 +0100 Subject: fix ShowEFBCopyRegions those fancy colors were the result of the usage of non-allocated heap Signed-off-by: Ryan Houdek --- Source/Core/VideoCommon/Src/BPFunctions.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Source/Core/VideoCommon/Src/BPFunctions.cpp') diff --git a/Source/Core/VideoCommon/Src/BPFunctions.cpp b/Source/Core/VideoCommon/Src/BPFunctions.cpp index cddeae3000..b9a76ba7b6 100644 --- a/Source/Core/VideoCommon/Src/BPFunctions.cpp +++ b/Source/Core/VideoCommon/Src/BPFunctions.cpp @@ -236,7 +236,7 @@ bool GetConfig(const int &type) case CONFIG_DISABLEFOG: return g_ActiveConfig.bDisableFog; case CONFIG_SHOWEFBREGIONS: - return false; + return g_ActiveConfig.bShowEFBCopyRegions; default: PanicAlert("GetConfig Error: Unknown Config Type!"); return false; -- cgit v1.2.3