mm/src/audio/code_8019AF00.c, branch gha Decompilation of The Legend of Zelda: Majora’s Mask FALLTHROUGH Attribute, switch cleanup (#1719) 2024-10-20T00:56:35+00:00 engineer124 47598039+engineer124@users.noreply.github.com 2024-10-20T00:56:35+00:00 1b7c9ecb88fe542ebd383053f480b156ab832a5a * add fallthrough * attributes * fix warning 
* add fallthrough

* attributes

* fix warning
 [Audio 8/?] Check-in handwritten sequences, build sequences, automate various sfx arrays (#1679) 2024-09-15T22:26:32+00:00 Tharo 17233964+Thar0@users.noreply.github.com 2024-09-15T22:26:32+00:00 d14e1ac1dfcfaec4ea7ba7db99cc092692f64f67 * [Audio 8/?] Check-in handwritten sequences, build sequences, automate various sfx arrays * Fix whitespace in aseq.h * Suggested changes, adjust some MML syntax and add more instruction descriptions * Special case progress script (#9) * Hack progress script * Small adjustment to text fileSectionFixer * Add the dir of the input .seq file to the list of includes to sequence assembling so that assembler-level includes like .include or .incbin work intuitively * Remove old comment that was missed before * aseq.h tweaks * Review suggestions, aseq.h adjustments --------- Co-authored-by: Derek Hensley <hensley.derek58@gmail.com> 
* [Audio 8/?] Check-in handwritten sequences, build sequences, automate various sfx arrays

* Fix whitespace in aseq.h

* Suggested changes, adjust some MML syntax and add more instruction descriptions

* Special case progress script (#9)

* Hack progress script

* Small adjustment to text fileSectionFixer

* Add the dir of the input .seq file to the list of includes to sequence assembling so that assembler-level includes like .include or .incbin work intuitively

* Remove old comment that was missed before

* aseq.h tweaks

* Review suggestions, aseq.h adjustments

---------

Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
 Misc Cleanup 2 (#1521) 2024-03-23T11:04:07+00:00 engineer124 47598039+engineer124@users.noreply.github.com 2024-03-23T11:04:07+00:00 5bef89a6ff33c3e84ad58d201bd1996a0d9f7db4 * begin cleanup * more cleanup * more cleanup * more cleanup * more cleanup * more cleanup * fake matches * more cleanup * more cleanup * small thing * PR Review * PR Review 
* begin cleanup

* more cleanup

* more cleanup

* more cleanup

* more cleanup

* more cleanup

* fake matches

* more cleanup

* more cleanup

* small thing

* PR Review

* PR Review
 Audio Voice Decompiled (#1490) 2023-11-17T01:29:42+00:00 engineer124 47598039+engineer124@users.noreply.github.com 2023-11-17T01:29:42+00:00 8ab62788b2ad7d8f5c2b556b2416f06c29b6f5be * Add Tharo's documentation comments * Voice progress * Match osVoiceControlGain * Match osVoiceStartReadData * Cleanup * Add docs from n64devkit * WIP on osVoiceGetReadData * Add comment * Match voiceinit.c * Remove CONT_ERR, already present in controller.h * Really close to matching osVoiceStopReadData * Progress on voicecheckword * Match osVoiceSetWord * Add error codes * Matched __osVoiceContRead2... Somehow... * Add small amount of docs * __osVoiceContRead36 was basically identical from __osVoiceContRead2 * docs, but maybe a little carried away * Match __osVoiceContWrite4, Write is very similar to Read * Match __osVoiceContWrite20 from __osVoiceContWrite4, ez * Some docs * Improve osVoiceGetReadData * Match osVoiceCheckWord * currentSyllable -> currSyllable * Match osVoiceMaskDictionary * Match __osVoiceSetADConverter * Meme matched osVoiceStopReadData * small cleanup * Missed macros * osVoiceGetReadData Meme Match * Small clean-up * format * Properly split voice files from code * Use proper flags for voice files * Add basic docs for func_801A5AF0 * Import Voice Data * Update matching functions in code_801A51F0 from audio WIP * Update matching functions in code_801A4EB0 from audio WIP * Match func_801A5A1C * Match func_801A5228 * Match func_801A54D0 * Doc padmgr functions used * Match func_801A5680, it's near identical to func_801A54D0 * code_801A51F0 OK * Match func_801A4EB8 * Match func_801A4FD8 (mips2c got it matching directly) * code_801A4EB0 & all of voice, OK * Import bss * Better match for func_801A5A1C * format * Cleanup * Clean up dictionary * Introduce OSVoiceDictionary * More voice docs * Fix bss * Import code_801A4EB0 data * Introduce Word Id enum * Dictionary: u8 -> u16 * Introduce bgms * Fill in bgm enums * Rename bgm to clearer names * Fix spacing * Fix "No_Music" define * remove comment * import rodata * Improve bgm names, found another seqId function * Another seqId function * Another name change * Woods of Mystery -> Sarias Song * Fix match in osVoiceControlGain * Fix bss reordering * Fix bss file split * add saria's song bgm to pierre * Another bgm function found! * Add bgm's to `gSaveContext.seqIndex` * Fix BSS * fix bss * Fix bss * cleanup * more cleanup * cow voice weekeventflag * small cleanup * some docs * cleanup var * global * more docs * PR Review --------- Co-authored-by: Elliptic Ellipsis <elliptic.ellipsis@gmail.com> Co-authored-by: Derek Hensley <hensley.derek58@gmail.com> 
* Add Tharo's documentation comments

* Voice progress

* Match osVoiceControlGain

* Match osVoiceStartReadData

* Cleanup

* Add docs from n64devkit

* WIP on osVoiceGetReadData

* Add comment

* Match voiceinit.c

* Remove CONT_ERR, already present in controller.h

* Really close to matching osVoiceStopReadData

* Progress on voicecheckword

* Match osVoiceSetWord

* Add error codes

* Matched __osVoiceContRead2... Somehow...

* Add small amount of docs

* __osVoiceContRead36 was basically identical from __osVoiceContRead2

* docs, but maybe a little carried away

* Match __osVoiceContWrite4, Write is very similar to Read

* Match __osVoiceContWrite20 from __osVoiceContWrite4, ez

* Some docs

* Improve osVoiceGetReadData

* Match osVoiceCheckWord

* currentSyllable -> currSyllable

* Match osVoiceMaskDictionary

* Match __osVoiceSetADConverter

* Meme matched osVoiceStopReadData

* small cleanup

* Missed macros

* osVoiceGetReadData Meme Match

* Small clean-up

* format

* Properly split voice files from code

* Use proper flags for voice files

* Add basic docs for func_801A5AF0

* Import Voice Data

* Update matching functions in code_801A51F0 from audio WIP

* Update matching functions in code_801A4EB0 from audio WIP

* Match func_801A5A1C

* Match func_801A5228

* Match func_801A54D0

* Doc padmgr functions used

* Match func_801A5680, it's near identical to func_801A54D0

* code_801A51F0 OK

* Match func_801A4EB8

* Match func_801A4FD8 (mips2c got it matching directly)

* code_801A4EB0 & all of voice, OK

* Import bss

* Better match for func_801A5A1C

* format

* Cleanup

* Clean up dictionary

* Introduce OSVoiceDictionary

* More voice docs

* Fix bss

* Import code_801A4EB0 data

* Introduce Word Id enum

* Dictionary: u8 -> u16

* Introduce bgms

* Fill in bgm enums

* Rename bgm to clearer names

* Fix spacing

* Fix "No_Music" define

* remove comment

* import rodata

* Improve bgm names, found another seqId function

* Another seqId function

* Another name change

* Woods of Mystery -> Sarias Song

* Fix match in osVoiceControlGain

* Fix bss reordering

* Fix bss file split

* add saria's song bgm to pierre

* Another bgm function found!

* Add bgm's to `gSaveContext.seqIndex`

* Fix BSS

* fix bss

* Fix bss

* cleanup

* more cleanup

* cow voice weekeventflag

* small cleanup

* some docs

* cleanup var

* global

* more docs

* PR Review

---------

Co-authored-by: Elliptic Ellipsis <elliptic.ellipsis@gmail.com>
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
 Match `AudioOcarina_CreateCustomSequence` (code_8019AF00.c OK) (#1468) 2023-11-07T04:29:04+00:00 engineer124 47598039+engineer124@users.noreply.github.com 2023-11-07T04:29:04+00:00 23fdf697343d8abeac43dd0c334cd68d3560060b * match AudioOcarina_CreateCustomSequence * cleanup 
* match AudioOcarina_CreateCustomSequence

* cleanup
 Decompile Remaining code_8019AF00.c Functions (1 non-matching) (#1442) 2023-10-26T13:09:08+00:00 engineer124 47598039+engineer124@users.noreply.github.com 2023-10-26T13:09:08+00:00 6aaeb80f992865e1a68eed611b926f8b41ad3ed6 * remaining code_8019AF00 functions * oops * decimal duration * PR Review 
* remaining code_8019AF00 functions

* oops

* decimal duration

* PR Review
 Audio Sequences Decompiled & Documented (z_obj_sound OK, more code_8019AF00.c) (#1407) 2023-10-13T20:39:10+00:00 engineer124 47598039+engineer124@users.noreply.github.com 2023-10-13T20:39:10+00:00 93713a1da05ba0c728a0da3eb07d281d700341eb * import audio docs * cleanup * SEQ_SCREEN_WEIGHTED_DIST * PR * PR 
* import audio docs

* cleanup

* SEQ_SCREEN_WEIGHTED_DIST

* PR

* PR
 Provide original sequence names for all BGM and rename some sequences (#1311) 2023-07-10T22:30:21+00:00 Tom Overton tom-overton@users.noreply.github.com 2023-07-10T22:30:21+00:00 7cbd63c33ddc7f3a22f38f8926a1d07c4cd00609 * Provide original sequence names for all BGM and rename some sequences * Include official soundtrack names, respond to reviews, rename some more sequences based on new evidence * Forgot to rename the shooting gallery sequence, oops * Rephrase the comment on NA_BGM_CLOCK_TOWN_MAIN_SEQUENCE 
* Provide original sequence names for all BGM and rename some sequences

* Include official soundtrack names, respond to reviews, rename some more sequences based on new evidence

* Forgot to rename the shooting gallery sequence, oops

* Rephrase the comment on NA_BGM_CLOCK_TOWN_MAIN_SEQUENCE
 Audio Sfx Functions Decompiled and Documented (code_8019AF00.c) (#1242) 2023-06-21T03:13:51+00:00 engineer124 47598039+engineer124@users.noreply.github.com 2023-06-21T03:13:51+00:00 9c0fc94fe3c331fb125a4e4c23409f527f35c023 * sfx decomp and docs * function headers * namefixer * oops * better sfx name * PR review * namefixer * PR review * float * namefixer * namefixer * namefixer * PR Suggestions 
* sfx decomp and docs

* function headers

* namefixer

* oops

* better sfx name

* PR review

* namefixer

* PR review

* float

* namefixer

* namefixer

* namefixer

* PR Suggestions
 Misc Cleanup 3 (#1268) 2023-06-05T22:57:45+00:00 engineer124 47598039+engineer124@users.noreply.github.com 2023-06-05T22:57:45+00:00 f92a61db27ed8ee213072df11169777c6794bc1b * begin more cleanup * more enums * typo * == * fix go.h * fix RaceDogInfo struct * PR Review * PR Suggestions * missed one * missed even more * fix params * fix number 
* begin more cleanup

* more enums

* typo

* ==

* fix go.h

* fix RaceDogInfo struct

* PR Review

* PR Suggestions

* missed one

* missed even more

* fix params

* fix number