oot/src/code/jpegdecoder.c, branch main Decompilation of The Legend of Zelda: Ocarina of Time Reduce overlay dependencies on global.h (7) (#2472) 2025-02-16T20:33:55+00:00 mzxrules mzxrules@gmail.com 2025-02-16T20:33:55+00:00 652478c338b0a9aa04f3d8f908a2c44a429e94f3 * z64env_flags, z64quest_hint_commands * z64cutscene_spline, z64save.h moved from z64.h * bss * pr suggestion * bss * suggestions 
* z64env_flags, z64quest_hint_commands

* z64cutscene_spline, z64save.h moved from z64.h

* bss

* pr suggestion

* bss

* suggestions
 [headers 11] stackcheck.h, jpeg functions (#2171) 2024-09-08T16:02:38+00:00 Dragorn421 Dragorn421@users.noreply.github.com 2024-09-08T16:02:38+00:00 de1a08c0612c36ca7528b9208a5a28d47d6b830a * [headers 11] stackcheck.h, jpeg functions * bss 
* [headers 11] stackcheck.h, jpeg functions

* bss
 Fix misc 21 (#1573) 2023-11-12T21:59:52+00:00 Dragorn421 Dragorn421@users.noreply.github.com 2023-11-12T21:59:52+00:00 4c75260097135edb171501942e451474fce66c50 * Make `sNew` in (unused) `code_800FC620.c` a string It is passed as a filename to `__osMallocDebug` so should be a nul-terminated string, not a char[3] missing an explicit \0 * Fix gcc warning in `JpegDecoder_ParseNextSymbol` about SLL on negative value -1U is an unsigned value, aka 0xFFFFFFFF I keep -1 because it seems that's what a jpeg standard has too References: https://stackoverflow.com/questions/40508958/shifting-a-negative-signed-value-is-undefined https://www.w3.org/Graphics/JPEG/itu-t81.pdf (page 105, figure F.12) * Small cleanup * Fix few mistakes (thanks gcc warnings) * Add `@bug` in file select settings draw code, using the wrong array * format * format main * rename arg for a happy formatter * Move important function call out of a printf 
* Make `sNew` in (unused) `code_800FC620.c` a string

It is passed as a filename to `__osMallocDebug` so should be a nul-terminated string, not a char[3] missing an explicit \0

* Fix gcc warning in `JpegDecoder_ParseNextSymbol` about SLL on negative value

-1U is an unsigned value, aka 0xFFFFFFFF
I keep -1 because it seems that's what a jpeg standard has too

References:
https://stackoverflow.com/questions/40508958/shifting-a-negative-signed-value-is-undefined
https://www.w3.org/Graphics/JPEG/itu-t81.pdf (page 105, figure F.12)

* Small cleanup

* Fix few mistakes (thanks gcc warnings)

* Add `@bug` in file select settings draw code, using the wrong array

* format

* format main

* rename arg for a happy formatter

* Move important function call out of a printf
 Fix misc 15 (#1298) 2022-06-24T23:45:05+00:00 Dragorn421 Dragorn421@users.noreply.github.com 2022-06-24T23:45:05+00:00 397e481f9a3eedf2123cc2fc149468a96b473e88 * Use `SCENE_` enum more * Decimal for pos in `D_8011F9B8` * `__osEventStateTab`: length `OS_NUM_EVENTS + 1` -> `OS_NUM_EVENTS` * thone -> throne * `s` on local data * minor sfxId cleanup * Run formatter * Fixup 0x19 + 1 = 0x1A, not 0x20 lol * Tlut -> TLUT * DemoKankyo params usage cleanup * Some proofreading (up to z_actor.c) * Revert 0 -> sfxId, add todo comment (sfxId=0 is weird apparently) * `sZdWaterBox` -> `sZorasDomainWaterBox` * `msgMode == MSGMODE_`, not `GAMEMODE_` (my bad Sadge) 
* Use `SCENE_` enum more

* Decimal for pos in `D_8011F9B8`

* `__osEventStateTab`: length `OS_NUM_EVENTS + 1` -> `OS_NUM_EVENTS`

* thone -> throne

* `s` on local data

* minor sfxId cleanup

* Run formatter

* Fixup 0x19 + 1 = 0x1A, not 0x20 lol

* Tlut -> TLUT

* DemoKankyo params usage cleanup

* Some proofreading (up to z_actor.c)

* Revert 0 -> sfxId, add todo comment (sfxId=0 is weird apparently)

* `sZdWaterBox` -> `sZorasDomainWaterBox`

* `msgMode == MSGMODE_`, not `GAMEMODE_` (my bad Sadge)
 Misc Cleanup 2 (#1007) 2021-11-30T23:40:42+00:00 Dragorn421 Dragorn421@users.noreply.github.com 2021-11-30T23:40:42+00:00 669732abbe78ad6dad6b5f7273f595befd630cba * Cleanup `UNK_TYPE`, `UNK_PTR` usage * Add some missing empty lines after declarations * Remove some legacy comments from non-matching times * Fix some grammar (mostly "it's"/"its") * Use proper names for two symbols after ZAPD bugfix * Cleanup `place_title_cards.xml` * Use `NULL` to check against `D_8012D260` pointer * Parentheses around some macro arguments * wip proofread headers up to z64animation.h 
* Cleanup `UNK_TYPE`, `UNK_PTR` usage

* Add some missing empty lines after declarations

* Remove some legacy comments from non-matching times

* Fix some grammar (mostly "it's"/"its")

* Use proper names for two symbols after ZAPD bugfix

* Cleanup `place_title_cards.xml`

* Use `NULL` to check against `D_8012D260` pointer

* Parentheses around some macro arguments

* wip proofread headers up to z64animation.h
 Fix most compiler warnings in the boot and code segments (#674) 2021-02-14T00:49:40+00:00 Tharo 17233964+Thar0@users.noreply.github.com 2021-02-14T00:49:40+00:00 f9d96d9f73ac090245a518ec04f3fa0e50655d1e * Less warnings in boot & code segments * few more warnings gone * Ran formatter * z_view warning gone * -> 1 * f31 -> 31 * Remove function casts * Few more small improvements * Separate declaration and assignment in func_80091738 and Item_Give Co-authored-by: Thar0 <maximilianc64@gmail.com> 
* Less warnings in boot & code segments

* few more warnings gone

* Ran formatter

* z_view warning gone

* -> 1

* f31 -> 31

* Remove function casts

* Few more small improvements

* Separate declaration and assignment in func_80091738 and Item_Give

Co-authored-by: Thar0 <maximilianc64@gmail.com>
 jpegdecoder OK (#574) 2020-12-30T03:45:01+00:00 petrie911 69443847+petrie911@users.noreply.github.com 2020-12-30T03:45:01+00:00 1facd83c3866041b4b66f583773455bc87fb62b9 * new match * and the .s * merge Co-authored-by: petrie911 <pmontag@DESKTOP-LG8A167.localdomain> 
* new match

* and the .s

* merge

Co-authored-by: petrie911 <pmontag@DESKTOP-LG8A167.localdomain>
 libultra cleanup (#215) 2020-10-03T15:22:44+00:00 Random 28494085+Random06457@users.noreply.github.com 2020-10-03T15:22:44+00:00 174af7384d1cfcbf15da02d9069bf02bdc433c20 * cleanup libultra * fixes - use quotes instead of <> for includes - add macros for zelda specific thread priorities - fix Makefile - properly format the remaining pfs structs * fix button macros + add CHECK_BTN_ANY/CHECK_BTN_ALL * remove ULTRA_ABS * fix includes * update z_player.c/z_lib.c + run format.sh * merge upstream/master * fix include in En_Goroiwa * fix includes 
* cleanup libultra

* fixes

- use quotes instead of <> for includes
- add macros for zelda specific thread priorities
- fix Makefile
- properly format the remaining pfs structs

* fix button macros + add CHECK_BTN_ANY/CHECK_BTN_ALL

* remove ULTRA_ABS

* fix includes

* update z_player.c/z_lib.c + run format.sh

* merge upstream/master

* fix include in En_Goroiwa

* fix includes
 Decompile jpegdecoder.c, padsetup.c and code_800C3C20.c (#217) 2020-06-21T22:43:14+00:00 Random 28494085+Random06457@users.noreply.github.com 2020-06-21T22:43:14+00:00 ab1ec89f22808c38426f7e0d4e4f0e1a5bc3aec9 * Decompile jpegdecoder.c, padsetup.c and code_800C3C20.c * change func_800C3C20's prototype and rename some fields in jpeg related structs * Fix comment in Jpeg_GetU16 and change func_800C3C20 * use a switch in padsetup.c 
* Decompile jpegdecoder.c, padsetup.c and code_800C3C20.c

* change func_800C3C20's prototype and rename some fields in jpeg related structs

* Fix comment in Jpeg_GetU16 and change func_800C3C20

* use a switch in padsetup.c