<feed xmlns='http://www.w3.org/2005/Atom'>
<title>oot/src/code/z_common_data.c, branch main</title>
<subtitle>Decompilation of The Legend of Zelda: Ocarina of Time</subtitle>
<link rel='alternate' type='text/html' href='https://git.dog6.net/oot/'/>
<entry>
<title>Document `Save.cutsceneIndex` and adjacent data / code (#2286)</title>
<updated>2025-06-17T13:54:52+00:00</updated>
<author>
<name>Leonid Kapitonov</name>
<email>Feacur@gmail.com</email>
</author>
<published>2025-06-17T13:54:52+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/oot/commit/?id=b11fdab792f1e7c4b71cfa7568963fad1c7d742d'/>
<id>b11fdab792f1e7c4b71cfa7568963fad1c7d742d</id>
<content type='text'>
* introduce `enum CutsceneIndex` as a first step

* crudely rename `enum CutsceneIndex` entries

* run `check_format.py ...` separetely

so that it doesn't clutter previous commit. still, allowing `clangd LSP` to run format-on-save yields inconsistent results for me with the project's tooling, especially for header files

* apply a draft PR suggestion

Co-authored-by: mzxrules &lt;mzxrules@gmail.com&gt;

* rename `CS_INDEX_*` with PR suggestions

and some additional observations
reverified with
&gt; `check_format.py ...`
&gt; `make ...`

additionally:
- current clang-format lacks a rule for trailing commas
- compiler says about them `cfe: Warning 624`

* improve `CS_INDEX_*` naming, rem `ENTRANCE` suffix

https://github.com/zeldaret/oot/pull/2286#discussion_r1829165205

reverified with
&gt; `check_format.py ...`
&gt; `make ...`

* apply Jenkins fixes

https://jenkins.deco.mp/job/OOT/job/PR-2286/4/console

hmm, i do need this automation locally to

* apply a PR suggestion

https://github.com/zeldaret/oot/pull/2286#discussion_r1829219841

* remove redundant comments, fix the header comment

and add a comment chunk from https://github.com/zeldaret/oot/pull/2286#discussion_r1829108940

* rename the flag for freeing `nextCutsceneIndex`

* rename the flag for automatic `sceneLayer` calc

it gets assigned to the `nextCutsceneIndex`,
so `CS_INDEX_NONE` name was misleading

* use explicit scene layer names instead of numbers

* ok, now the last two `CS_INDEX_*` are less unknown

the purpose of `CS_INDEX_BARRIER` is not quite clear still

* apply Jenkins fixes

https://jenkins.deco.mp/job/OOT/job/PR-2286/14/console

* run `fix_bss` locally

`ntsc-1.2` refused to comply though

* revert all local to the branch bss shifts

* ugh, use defines instead of an enum

probably size of enum entries doesn't match well? originally these were
just numbers. besides, not like it's a real enumeration from zero to a
value or some bit flags

* still, add a BSS pragma for `z_demo.c`

* apply review changes

* factor out a cutscene layer formula

* give scene layers names throughout code

* apply Jenkins fixes

https://jenkins.deco.mp/job/OOT/job/PR-2286/32/console

* tweak `CS_INDEX` descriptions

* apply PR review suggestions

* rename "auto" -&gt; "default"

* apply PR review suggestions

https://github.com/zeldaret/oot/pull/2286#discussion_r1868693980

essentially reverts 106cb1021be88f745ee303838c11c7d7cbf9c79d, except for 2 generic `z_scene.c` lines

* apply Jenkins fixes

https://jenkins.deco.mp/job/OOT/job/PR-2286/77/console

* Apply suggestions from code review

Co-authored-by: Dragorn421 &lt;Dragorn421@users.noreply.github.com&gt;
Co-authored-by: mzxrules &lt;mzxrules@gmail.com&gt;

* apply Jenkins fixes

https://jenkins.deco.mp/job/OOT/job/PR-2286/175/console

* Move CS_INDEX_* macros to z64save.h, with the definition of gSaveContext.save.cutsceneIndex

* `#define CS_INDEX_D 0xFFFD` and co.

Co-authored-by: cadmic &lt;cadmic24@gmail.com&gt;

* add comment on CS_INDEX_D

* review

* CS_INDEX_NONE is back

* bss

* expand comment about 0xFFFD

* fix comment about 0xFFFF usage

* review

---------

Co-authored-by: mzxrules &lt;mzxrules@gmail.com&gt;
Co-authored-by: Dragorn421 &lt;Dragorn421@users.noreply.github.com&gt;
Co-authored-by: cadmic &lt;cadmic24@gmail.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* introduce `enum CutsceneIndex` as a first step

* crudely rename `enum CutsceneIndex` entries

* run `check_format.py ...` separetely

so that it doesn't clutter previous commit. still, allowing `clangd LSP` to run format-on-save yields inconsistent results for me with the project's tooling, especially for header files

* apply a draft PR suggestion

Co-authored-by: mzxrules &lt;mzxrules@gmail.com&gt;

* rename `CS_INDEX_*` with PR suggestions

and some additional observations
reverified with
&gt; `check_format.py ...`
&gt; `make ...`

additionally:
- current clang-format lacks a rule for trailing commas
- compiler says about them `cfe: Warning 624`

* improve `CS_INDEX_*` naming, rem `ENTRANCE` suffix

https://github.com/zeldaret/oot/pull/2286#discussion_r1829165205

reverified with
&gt; `check_format.py ...`
&gt; `make ...`

* apply Jenkins fixes

https://jenkins.deco.mp/job/OOT/job/PR-2286/4/console

hmm, i do need this automation locally to

* apply a PR suggestion

https://github.com/zeldaret/oot/pull/2286#discussion_r1829219841

* remove redundant comments, fix the header comment

and add a comment chunk from https://github.com/zeldaret/oot/pull/2286#discussion_r1829108940

* rename the flag for freeing `nextCutsceneIndex`

* rename the flag for automatic `sceneLayer` calc

it gets assigned to the `nextCutsceneIndex`,
so `CS_INDEX_NONE` name was misleading

* use explicit scene layer names instead of numbers

* ok, now the last two `CS_INDEX_*` are less unknown

the purpose of `CS_INDEX_BARRIER` is not quite clear still

* apply Jenkins fixes

https://jenkins.deco.mp/job/OOT/job/PR-2286/14/console

* run `fix_bss` locally

`ntsc-1.2` refused to comply though

* revert all local to the branch bss shifts

* ugh, use defines instead of an enum

probably size of enum entries doesn't match well? originally these were
just numbers. besides, not like it's a real enumeration from zero to a
value or some bit flags

* still, add a BSS pragma for `z_demo.c`

* apply review changes

* factor out a cutscene layer formula

* give scene layers names throughout code

* apply Jenkins fixes

https://jenkins.deco.mp/job/OOT/job/PR-2286/32/console

* tweak `CS_INDEX` descriptions

* apply PR review suggestions

* rename "auto" -&gt; "default"

* apply PR review suggestions

https://github.com/zeldaret/oot/pull/2286#discussion_r1868693980

essentially reverts 106cb1021be88f745ee303838c11c7d7cbf9c79d, except for 2 generic `z_scene.c` lines

* apply Jenkins fixes

https://jenkins.deco.mp/job/OOT/job/PR-2286/77/console

* Apply suggestions from code review

Co-authored-by: Dragorn421 &lt;Dragorn421@users.noreply.github.com&gt;
Co-authored-by: mzxrules &lt;mzxrules@gmail.com&gt;

* apply Jenkins fixes

https://jenkins.deco.mp/job/OOT/job/PR-2286/175/console

* Move CS_INDEX_* macros to z64save.h, with the definition of gSaveContext.save.cutsceneIndex

* `#define CS_INDEX_D 0xFFFD` and co.

Co-authored-by: cadmic &lt;cadmic24@gmail.com&gt;

* add comment on CS_INDEX_D

* review

* CS_INDEX_NONE is back

* bss

* expand comment about 0xFFFD

* fix comment about 0xFFFF usage

* review

---------

Co-authored-by: mzxrules &lt;mzxrules@gmail.com&gt;
Co-authored-by: Dragorn421 &lt;Dragorn421@users.noreply.github.com&gt;
Co-authored-by: cadmic &lt;cadmic24@gmail.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>Remove "z64" prefix from all headers (#2518)</title>
<updated>2025-06-04T18:38:33+00:00</updated>
<author>
<name>fig02</name>
<email>fig02srl@gmail.com</email>
</author>
<published>2025-06-04T18:38:33+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/oot/commit/?id=28cc9d68cfe4a037eb232d5465b84a943539bca3'/>
<id>28cc9d68cfe4a037eb232d5465b84a943539bca3</id>
<content type='text'>
* z64 - a

* z64 - b

* z64 - c

* z64 - d

* z64 - e

* z64 - f

* z64 - g

* z64 - h

* z64 - i

* z64 - l

* z64 - m

* z64 - o

* z64 - p

* z64 - q

* z64 - r

* z64 - s

* z64 - t

* z64 - v

* restore file

* fix merge

* fix merge

---------

Co-authored-by: Dragorn421 &lt;Dragorn421@users.noreply.github.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* z64 - a

* z64 - b

* z64 - c

* z64 - d

* z64 - e

* z64 - f

* z64 - g

* z64 - h

* z64 - i

* z64 - l

* z64 - m

* z64 - o

* z64 - p

* z64 - q

* z64 - r

* z64 - s

* z64 - t

* z64 - v

* restore file

* fix merge

* fix merge

---------

Co-authored-by: Dragorn421 &lt;Dragorn421@users.noreply.github.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>Cleanup includes in header files (#2540)</title>
<updated>2025-05-24T20:20:51+00:00</updated>
<author>
<name>Dragorn421</name>
<email>Dragorn421@users.noreply.github.com</email>
</author>
<published>2025-05-24T20:20:51+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/oot/commit/?id=6d56b1b8e0410da164f3e5d0d62f4a9d472a1445'/>
<id>6d56b1b8e0410da164f3e5d0d62f4a9d472a1445</id>
<content type='text'>
* Cleanup includes in header files

* include libc headers without libc/ prefix

* fix

* fix2

* fix3

* fix4

* some bss lol

* bss

* fix</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* Cleanup includes in header files

* include libc headers without libc/ prefix

* fix

* fix2

* fix3

* fix4

* some bss lol

* bss

* fix</pre>
</div>
</content>
</entry>
<entry>
<title>Reduce dependencies on global.h (10) (#2490)</title>
<updated>2025-02-26T22:18:30+00:00</updated>
<author>
<name>mzxrules</name>
<email>mzxrules@gmail.com</email>
</author>
<published>2025-02-26T22:18:30+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/oot/commit/?id=cf1a39c26fca0f7827fef79d08b114fde1c43cce'/>
<id>cf1a39c26fca0f7827fef79d08b114fde1c43cce</id>
<content type='text'>
* reduce z64.h size

* fix z_cheap_proc.inc.c

* ,bss

* remove temp delcaration</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* reduce z64.h size

* fix z_cheap_proc.inc.c

* ,bss

* remove temp delcaration</pre>
</div>
</content>
</entry>
<entry>
<title>Create headers for Game States (#2482)</title>
<updated>2025-02-20T12:50:13+00:00</updated>
<author>
<name>fig02</name>
<email>fig02srl@gmail.com</email>
</author>
<published>2025-02-20T12:50:13+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/oot/commit/?id=2e4d7a11012bf90ac21086ec1a9cd23f54413e86'/>
<id>2e4d7a11012bf90ac21086ec1a9cd23f54413e86</id>
<content type='text'>
* make headers for gamestates

* fixes

* fixes 2

* bss</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* make headers for gamestates

* fixes

* fixes 2

* bss</pre>
</div>
</content>
</entry>
<entry>
<title>Reduce overlay dependencies on global.h (7) (#2472)</title>
<updated>2025-02-16T20:33:55+00:00</updated>
<author>
<name>mzxrules</name>
<email>mzxrules@gmail.com</email>
</author>
<published>2025-02-16T20:33:55+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/oot/commit/?id=652478c338b0a9aa04f3d8f908a2c44a429e94f3'/>
<id>652478c338b0a9aa04f3d8f908a2c44a429e94f3</id>
<content type='text'>
* z64env_flags, z64quest_hint_commands

* z64cutscene_spline, z64save.h moved from z64.h

* bss

* pr suggestion

* bss

* suggestions</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* z64env_flags, z64quest_hint_commands

* z64cutscene_spline, z64save.h moved from z64.h

* bss

* pr suggestion

* bss

* suggestions</pre>
</div>
</content>
</entry>
<entry>
<title>Use enums for settings in SRAM header (#2429)</title>
<updated>2025-02-16T00:36:19+00:00</updated>
<author>
<name>cadmic</name>
<email>cadmic24@gmail.com</email>
</author>
<published>2025-02-16T00:36:19+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/oot/commit/?id=aba3720d62f4282d2403324ed0cafa240c4dbb03'/>
<id>aba3720d62f4282d2403324ed0cafa240c4dbb03</id>
<content type='text'>
* Use enums for settings in SRAM header

* Fix bss

* Uglify z_en_mag to match ique</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* Use enums for settings in SRAM header

* Fix bss

* Uglify z_en_mag to match ique</pre>
</div>
</content>
</entry>
<entry>
<title>Reduce overlay dependencies on global.h (3) (#2449)</title>
<updated>2025-02-05T20:07:19+00:00</updated>
<author>
<name>mzxrules</name>
<email>mzxrules@gmail.com</email>
</author>
<published>2025-02-05T20:07:19+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/oot/commit/?id=54939bac3ac972a24918d3fdc97d58199ff54bc9'/>
<id>54939bac3ac972a24918d3fdc97d58199ff54bc9</id>
<content type='text'>
* kill more global.h references

* .format.py

* bss

* ique</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* kill more global.h references

* .format.py

* bss

* ique</pre>
</div>
</content>
</entry>
<entry>
<title>Finish matching ique-cn (#2451)</title>
<updated>2025-02-04T11:55:04+00:00</updated>
<author>
<name>Tharo</name>
<email>17233964+Thar0@users.noreply.github.com</email>
</author>
<published>2025-02-04T11:55:04+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/oot/commit/?id=c028db03b47f8b38bc2a1b87569fd7fae0ea9067'/>
<id>c028db03b47f8b38bc2a1b87569fd7fae0ea9067</id>
<content type='text'>
* git subrepo clone git@github.com:Thar0/com-plugin.git tools/com-plugin

subrepo:
  subdir:   "tools/com-plugin"
  merged:   "e8543312d"
upstream:
  origin:   "git@github.com:Thar0/com-plugin.git"
  branch:   "main"
  commit:   "e8543312d"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"

* ique-cn OK

* Review suggestions

* Most suggestions

* git subrepo pull tools/com-plugin

subrepo:
  subdir:   "tools/com-plugin"
  merged:   "81595ed1c"
upstream:
  origin:   "git@github.com:Thar0/com-plugin.git"
  branch:   "main"
  commit:   "81595ed1c"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"

* Fix other versions</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* git subrepo clone git@github.com:Thar0/com-plugin.git tools/com-plugin

subrepo:
  subdir:   "tools/com-plugin"
  merged:   "e8543312d"
upstream:
  origin:   "git@github.com:Thar0/com-plugin.git"
  branch:   "main"
  commit:   "e8543312d"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"

* ique-cn OK

* Review suggestions

* Most suggestions

* git subrepo pull tools/com-plugin

subrepo:
  subdir:   "tools/com-plugin"
  merged:   "81595ed1c"
upstream:
  origin:   "git@github.com:Thar0/com-plugin.git"
  branch:   "main"
  commit:   "81595ed1c"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"

* Fix other versions</pre>
</div>
</content>
</entry>
<entry>
<title>[iQue] Match z_end_title, z_construct, z_common_data, z_parameter, z_title, z_opening (#2424)</title>
<updated>2025-01-14T16:55:47+00:00</updated>
<author>
<name>cadmic</name>
<email>cadmic24@gmail.com</email>
</author>
<published>2025-01-14T16:55:47+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/oot/commit/?id=2b9b7a40b0f80199ca9776888bf6efdf85e8bd4c'/>
<id>2b9b7a40b0f80199ca9776888bf6efdf85e8bd4c</id>
<content type='text'>
* [iQue] Match z_end_title

* [iQue] Match z_construct

* [iQue] Match z_common_data

* [iQue] Match z_parameter

* [iQue] Match z_title, z_opening

* Actually match z_parameter

* Give up on stack issues

* this-&gt;exit = true</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* [iQue] Match z_end_title

* [iQue] Match z_construct

* [iQue] Match z_common_data

* [iQue] Match z_parameter

* [iQue] Match z_title, z_opening

* Actually match z_parameter

* Give up on stack issues

* this-&gt;exit = true</pre>
</div>
</content>
</entry>
</feed>
