* UNUSED attribute for variables and parameters in static segments and for all stack padding variables * No more unused variable warnings * Make pad variable names consistent * Small cleanup * Macro-ify stack padding * Use stack padding for more variables not previously named pad * Format * Check unused parameter on gamestate overlays and pause menu Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com> * Merge 2x u8 stack pads into 1x s16 stack pad in en_ik * Remove UNUSED from function prototypes * Suggested changes Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com> * More unused variables * Fix merge, updated for new versions * Format * questionable UNUSED and STACK_PAD more usage * format * format * one more STACK_PADS in z_kaleido_map.c --------- Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* Remove src/ from include path * Define includes ordering for src/ includes * Update includes.md
* Document pass on WaterBox code * implement suggestions, missing comment --------- Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* Document z_eff_ss_stone1.[ch] * Incorporate feedback from PR review. From https://github.com/zeldaret/oot/pull/2670: - Shortened excessively verbose suppressRTransFadeFlashAlphaStepAfterTwoFrames name to suppressFadeFlash - Fixed up comment that went waaaaaay beyond the column limit in z_eff_ss_stone1.h - Shortened comparison with 0 of variable bool semantics in z_eff_ss_stone1.c Signed-off-by: Gabriel Ravier <gabravier@gmail.com> * Fix misnaming from PR review and document some more From https://github.com/zeldaret/oot/pull/2670: - shortenFadeFlash is incorrect - renamed to freezeFadeFlash - Used `false` instead of 0 in EnArrow_Fly - Elaborated comments about what exactly freezeFadeFlash does Also added a few extra comments to z_eff_ss_stone1.c * Ran clang-format * More feedback from PR review, clarified comment From https://github.com/zeldaret/oot/pull/2670: - Change 0 to false in header comment - Remove verbose speculation about former use of unused variable - Made comment on use of viewDepth clearer - Separated matrix and gfx code with a newline Signed-off-by: Gabriel Ravier <gabravier@gmail.com> * Marked the "1500" as being in units --------- Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
* Commit and split gameplay_keep * Remove debugging bits * format * bss * merge gameplay_keep_0x400 into link_textures * Name some unused NTSC stuff * Rename files for some of the newly named unused NTSC stuff * name more gkeep files * format * spin_attack * name fish anims files * name some eff_ files * name a bunch more files * Add underscore in not-final names * cleanup limb enum names (remove g prefix) * split gameplay_keep_0x34020.c into gBugCrawlAnim.c + bug_skel.c * door.h -> door_skel.h * gArrowNAnim -> gArrowN_Anim * split arrow_anims into gArrow1_Anim + gArrow2_Anim * fix merge * bss * bss * Fix bss --------- Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* Add `SFX_PLAY_CENTERED` * Add `SFX_PLAY_AT_POS`
* z64 - a * z64 - b * z64 - c * z64 - d * z64 - e * z64 - f * z64 - g * z64 - h * z64 - i * z64 - l * z64 - m * z64 - o * z64 - p * z64 - q * z64 - r * z64 - s * z64 - t * z64 - v * restore file * fix merge * fix merge --------- Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* Commit (inline) some assets/overlays/ * rm padding * ovl_file_choose
* T() macro in various overlays * revert problematic T() in mir_ray