From feadb0d9ee54ecf9db8d8eaea03f5565e2011271 Mon Sep 17 00:00:00 2001 From: Roman971 <32455037+Roman971@users.noreply.github.com> Date: Mon, 13 Jun 2022 01:24:45 +0200 Subject: Enable more IDO warnings and apply fixes (#1264) * Update asm-processor and fix includes with EARLY * Enable more IDO warnings and disable unwanted warning 516 * Fix most new and remaining warnings * Improve skelanime comment * Improve asmproc pragma comment Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com> * Add suggested comment for a wrong prototype * Update asm-processor with the latest fix Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com> --- src/code/code_800F9280.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'src/code/code_800F9280.c') diff --git a/src/code/code_800F9280.c b/src/code/code_800F9280.c index 075d609aa..b1d28d681 100644 --- a/src/code/code_800F9280.c +++ b/src/code/code_800F9280.c @@ -96,9 +96,10 @@ typedef enum { } SeqCmdType; void Audio_ProcessSeqCmd(u32 cmd) { - s32 pad[2]; + s32 pad; u16 fadeTimer; u16 channelMask; + u32 channelMaskReversed; u16 val; u8 oldSpec; u8 spec; @@ -305,9 +306,10 @@ void Audio_ProcessSeqCmd(u32 cmd) { // stop channels Audio_QueueCmdS8(0x08000000 | _SHIFTL(playerIdx, 16, 8) | 0xFF00, 1); } - if ((channelMask ^ 0xFFFF) != 0) { + channelMaskReversed = channelMask ^ 0xFFFF; + if (channelMaskReversed != 0) { // with channel mask ~channelMask... - Audio_QueueCmdU16(0x90000000 | _SHIFTL(playerIdx, 16, 8), (channelMask ^ 0xFFFF)); + Audio_QueueCmdU16(0x90000000 | _SHIFTL(playerIdx, 16, 8), channelMaskReversed); // unstop channels Audio_QueueCmdS8(0x08000000 | _SHIFTL(playerIdx, 16, 8) | 0xFF00, 0); } -- cgit v1.2.3