From 877889c5105e59ee3aa4e57e53d3b0c5ffcfca77 Mon Sep 17 00:00:00 2001
From: LagoLunatic <LagoLunatic@users.noreply.github.com>
Date: Tue, 23 Dec 2025 18:53:10 -0500
Subject: Clean up code, remove fakematches, add UNUSED, enable warnings
 (#2992)

* Remove NDEBUG_DEFINED fakematch, clean up getName temps

* Fix ifdef

* Fix bad JSystem pch ifdef breaking decomp.me

* Remove Acch Chk fakematches

* Private Acch fields

* Fix some clangd errors in headers

* Add UNUSED macro for matching debug parameters

* Enable clangd unused-parameter warning

* Remove extern from initializers

Probably added by dol2asm?

* Fix process profile definitions

* Remove leftover dol2asm address comments

* Remove some unnecessary double casts

* Enable some more clangd warnings

* Fix missing usages of fopAcM_ct

* Fix wrong enum usage

* Fix more fakematches
---
 include/JSystem/JGadget/linklist.h    | 4 ++++
 include/JSystem/JSystem.h             | 2 +-
 include/JSystem/JUtility/JUTResFont.h | 4 ++--
 3 files changed, 7 insertions(+), 3 deletions(-)

(limited to 'include/JSystem')

diff --git a/include/JSystem/JGadget/linklist.h b/include/JSystem/JGadget/linklist.h
index 2fcb281f06..47a438ddb8 100644
--- a/include/JSystem/JGadget/linklist.h
+++ b/include/JSystem/JGadget/linklist.h
@@ -270,7 +270,11 @@ struct TLinkList_factory : public TLinkList<T, I> {
 
 template <typename T, int I>
 TLinkList_factory<T, I>::~TLinkList_factory() {
+#ifdef __MWERKS__
     JGADGET_ASSERTWARN(934, empty());
+#else
+    JGADGET_ASSERTWARN(934, this->empty());
+#endif
 }
 
 template <typename T>
diff --git a/include/JSystem/JSystem.h b/include/JSystem/JSystem.h
index 82231fe4d4..2b2f1143d0 100644
--- a/include/JSystem/JSystem.h
+++ b/include/JSystem/JSystem.h
@@ -1,7 +1,7 @@
 #ifndef JSYSTEM_H
 #define JSYSTEM_H
 
-#ifdef __MWERKS__
+#if __MWERKS__ && !defined(DECOMPCTX)
 #include "JSystem/JSystem.mch" // IWYU pragma: export
 #else
 #include "JSystem/JSystem.pch" // IWYU pragma: export
diff --git a/include/JSystem/JUtility/JUTResFont.h b/include/JSystem/JUtility/JUTResFont.h
index 819c77c05e..473a8e8f99 100644
--- a/include/JSystem/JUtility/JUTResFont.h
+++ b/include/JSystem/JUtility/JUTResFont.h
@@ -79,7 +79,7 @@ public:
     /* 0x6C */ const IsLeadByte_func* mIsLeadByte;
 };
 
-extern u8 const JUTResFONT_Ascfont_fix12[16736];
-extern u8 const JUTResFONT_Ascfont_fix16[16736];
+extern u8 const JUTResFONT_Ascfont_fix12[];
+extern u8 const JUTResFONT_Ascfont_fix16[];
 
 #endif /* JUTRESFONT_H */
-- 
cgit v1.2.3