Inlines, wrong indentation, enums, private fields, etc
* 99% match * Rewrote _execute to increase accuracy. Only issue in .text is a label not loading correctly. I have no idea how to fix this. * Equivalent. Weak func ordering. * 7% text * 28% text * 41% text * 65% text * Rewrote _execute to increase accuracy. Only issue in .text is a label not loading correctly. I have no idea how to fix this. * Equivalent. Weak func ordering. * 82% text * Equivalent. A lot of work is needed to name variables and clean up functions. Weak function ordering is wrong. * Cleaned some functions, named several variables, and began documenting dialog tree. * Naming a couple more variables * 21% text * change out getMySubstanceP for getMyIntegerP inline * 100% text * Refactor to use JUT_ASSERT macro * #181: d_a_tag_attention matching; TODO: implement chk_inside and dComIfGp_att_Look2RequestF * #181: continue working on d_a_tag_attention, matching almost complete * #181: revert naming class member (not certain enough) * #181: preliminary changes to resolve #784 comments regarding usage of debug maps * #181: commit suggestion by @WilliamArnett, fixing regalloc error Co-authored-by: WilliamArnett <149556961+WilliamArnett@users.noreply.github.com> * #181: fix missing curly bracket * #181: resolve #784 comments with the kind help of @WilliamArnett; move `daTagAttention::Act_c::chk_inside` to header file; split `plyrToObjVec` definition to match assembly; remove temp variable, use values directly and swap operands; implement `Look2RequestF` in `include/d/d_attention.h`; remove non-matching use of temp variable `iVar1` and replace `current.pos` with uninitialized variable in `daTagAttention::Act_c::_execute` * Update fork to match upstream * some changes * 12% text * 21% text * 26% text * 43% text * 51% text * Revert unnecessary file changes * Update d_a_tag_attention.cpp * 55% text * 52% text * 52% text * 56% text * 68% * 77% text * 100% matching minus regswap * 100% matching for retail * Many more demo matches * Fix broken match in _create() * Demo Match * Add some missing inlines * Fix dComIfGp_setMesgCameraInfoActor * More inline matching * fix broken demo match * Name some fields * Utilize EventBit enum * Name more fields, and add inline calls to d_a_npc_ls1 * Remove comments * Implement @LagoLunatic suggested changes * remove actor cast from dSnap_RegistFig calls * Fix broken match in eInit_ATTENTION_ * Second round of @LagoLunatic 's suggested changes --------- Co-authored-by: Skelp <skelp@pm.me> Co-authored-by: Skelp <59535863+Skelp@users.noreply.github.com>
* Fix some profile comments * Add missing static for local visibility data * Move proc name and draw priority enums to f_pc * Add _e suffix to daObjBarrier_c proc enum * Change proc name enum format to match TP * Change draw prio enum format to match TP * Change ItemNo enum format, finish fixing item names * Revert static for cb1 hio * Clean up formatting of profile comments * Fix comment alignment
* Match daNpc_Ls1_c::create, decideType, and ctor * 16% matching in .text -Match daNpc_Ls1_c::CreateHeap -Match daNpc_Ls1_c::itemCreateHeap -Match daNpc_Ls1_c::handCreateHeap -Match daNpc_Ls1_c::_delete -Match other trivial functions * Add hio_prm_c * 27% matching in .text -Add some static data -Match daNpc_Ls1_c::endEvent -Match daNpc_Ls1_c::isEventEntry -Match daNpc_Ls1_c::execute -Match daNpc_Ls1_c::bodyCreateHeap -Match some more trivial funcs * 33% matching in .text -Match daNpc_Ls1_c::create_init -Match daNpc_Ls1_c::chngAnmTag -Match daNpc_Ls1_c::ctrlAnmTag -Match init_LS1_#n() funcs -Match searchActor funcs * Add daNpc_Ls1_c::anm_prm_c struct and associated static data * 39% matching in .text - Matched daNpc_Ls1_matAnm_c::calc - Matched static node callbacks - Matched daNpc_Ls1_c::setAnm_anm - Matched daNpc_Ls1_c::setAnm_NUM - Matched daNpc_Ls1_c::chngAnmAtr - Misc code formatting changes * 52% matching in .text - Match daNpc_Ls1_c::play_animation - Match daNpc_Ls1_c::set_mtx - Match ResID funcs - Match daNpc_Ls1_c::setBtp - Match daNpc_Ls1_c::setMat - Match daNpc_Ls1_c::setBtk - Match daNpc_Ls1_c::init_texPttrnAnm - Match daNpc_Ls1_c::play_btp_anm - Match daNpc_Ls1_c::play_btk_anm - Match daNpc_Ls1_c::ctrlAnmAtr - Match daNpc_Ls1_c::setAnm_ATR - Match daNpc_Ls1_c::chk_parts_notMov - Match daNpc_Ls1_c::cut_init_LOK_PLYER - Match daNpc_Ls1_c::cut_move_WAI - Match daNpc_Ls1_c::cut_init_ANM_CHG - Match daNpc_Ls1_c::set_action * Update comments * Match daNpc_Ls1_c::_draw * 63% matching in .text - Match member J3D node callbacks - Match daNpc_Ls1_c::eye_ctrl - Match daNpc_Ls1_c::next_msgStatus - Match daNpc_Ls1_c::getMsg - Match daNpc_Ls1_c::chk_talk - Match daNpc_Ls1_c::setEyeCtrl - Match daNpc_Ls1_c::clrEyeCtrl - Match daNpc_Ls1_c::setAttention - Add misc enums - Add a_cut_tbl * 66% matching in .text - Matched daNpc_Ls1_c::searchByID - Matched daNpc_Ls1_c::partner_search_sub - Matched daNpc_Ls1_c::partner_search - Matched daNpc_Ls1_c::chkAttention - Marched daNpc_Ls1_c::shadowDraw * 75% matching in .text - Match daNpc_Ls1_c::anmAtr - Match daNpc_Ls1_c::getMsg_LS1_0 - Match daNpc_Ls1_c::chk_talk - Match daNpc_Ls1_c::setStt - Match daNpc_Ls1_c::get_playerEvnPos - Match daNpc_Ls1_c::chkTelescope - Match daNpc_Ls1_c::wait_1 - Match daNpc_Ls1_c::wait_4 - Match daNpc_Ls1_c::talk_1 - Match daNpc_Ls1_c::demo_action1 * Match daNpc_Ls1_c::wait_3 * 100% matching for both demo and retail * Update comments * Initial refactoring work * Renaming work & declaring functions in f_op_msg_mng header * Refactoring continued * Last bit of renaming work * Add missing include
This fixes the sdata linker error in the debug build.