Dynamic Actor IDs (#1729)

* Add dynamic actor IDs

* Convert Ivan to use new actor system

* attempt to fix linux build

* attempt to fix linux build

* merge

* Cleanup

* Fix missing math functions on Windows.

* Removes a stubbed function to fix non-windows builds.

* Update soh/soh/ActorDB.cpp

Co-authored-by: Adam Bird <Archez@users.noreply.github.com>

---------

Co-authored-by: Christopher Leggett <chris@leggett.dev>
Co-authored-by: Adam Bird <Archez@users.noreply.github.com>

4 files changed, 44 insertions, 255 deletions

diff --git a/soh/src/code/z_actor.c b/soh/src/code/z_actor.c
index c7db247f4..872752994 100644
--- a/soh/src/code/z_actor.c
+++ b/soh/src/code/z_actor.c
@@ -9,6 +9,7 @@
 #include "soh/frame_interpolation.h"
 #include "soh/Enhancements/enemyrandomizer.h"
 #include "soh/Enhancements/game-interactor/GameInteractor.h"
+#include "soh/ActorDB.h"
 
 #if defined(_MSC_VER) || defined(__GNUC__)
 #include <string.h>
@@ -1215,18 +1216,12 @@ void Actor_Init(Actor* actor, PlayState* play) {
 }
 
 void Actor_Destroy(Actor* actor, PlayState* play) {
-    ActorOverlay* overlayEntry;
-    char* name;
-
     if (actor->destroy != NULL) {
         actor->destroy(actor, play);
         actor->destroy = NULL;
     } else {
-        overlayEntry = actor->overlayEntry;
-        name = overlayEntry->name != NULL ? overlayEntry->name : "";
-
         // "No Actor class destruct [%s]"
-        osSyncPrintf("Ａｃｔｏｒクラス デストラクトがありません [%s]\n" VT_RST, name);
+        osSyncPrintf("Ａｃｔｏｒクラス デストラクトがありません [%s]\n" VT_RST, ActorDB_Retrieve(actor->id)->name);
     }
 }
 
@@ -2441,7 +2436,6 @@ void Actor_DisableLens(PlayState* play) {
 
 // Actor_InitContext
 void func_800304DC(PlayState* play, ActorContext* actorCtx, ActorEntry* actorEntry) {
-    ActorOverlay* overlayEntry;
     SavedSceneFlags* savedSceneFlags;
     s32 i;
 
@@ -2449,17 +2443,9 @@ void func_800304DC(PlayState* play, ActorContext* actorCtx, ActorEntry* actorEnt
 
     memset(actorCtx, 0, sizeof(*actorCtx));
 
-    ActorOverlayTable_Init();
     Matrix_MtxFCopy(&play->billboardMtxF, &gMtxFClear);
     Matrix_MtxFCopy(&play->viewProjectionMtxF, &gMtxFClear);
 
-    overlayEntry = &gActorOverlayTable[0];
-    for (i = 0; i < ARRAY_COUNT(gActorOverlayTable); i++) {
-        overlayEntry->loadedRamAddr = NULL;
-        overlayEntry->numLoaded = 0;
-        overlayEntry++;
-    }
-
     actorCtx->flags.chest = savedSceneFlags->chest;
     actorCtx->flags.swch = savedSceneFlags->swch;
     actorCtx->flags.clear = savedSceneFlags->clear;
@@ -2492,11 +2478,6 @@ void Actor_UpdateAll(PlayState* play, ActorContext* actorCtx) {
 
     player = GET_PLAYER(play);
 
-    if (0) {
-        // This ASSERT is optimized out but it exists due to its presence in rodata
-        ASSERT(gMaxActorId == ACTOR_ID_MAX);
-    }
-
     sp74 = NULL;
     unkFlag = 0;
 
@@ -2625,16 +2606,15 @@ void Actor_UpdateAll(PlayState* play, ActorContext* actorCtx) {
 }
 
 void Actor_FaultPrint(Actor* actor, char* command) {
-    ActorOverlay* overlayEntry;
     char* name;
 
-    if ((actor == NULL) || (actor->overlayEntry == NULL)) {
+    if (actor == NULL) {
         FaultDrawer_SetCursor(48, 24);
         FaultDrawer_Printf("ACTOR NAME is NULL");
+        return;
     }
 
-    overlayEntry = actor->overlayEntry;
-    name = overlayEntry->name != NULL ? overlayEntry->name : "";
+    name = ActorDB_Retrieve(actor->id)->name;
 
     osSyncPrintf("アクターの名前(%08x:%s)\n", actor, name); // "Actor name (%08x:%s)"
 
@@ -2887,8 +2867,7 @@ void func_800315AC(PlayState* play, ActorContext* actorCtx) {
         actor = actorListEntry->head;
 
         while (actor != NULL) {
-            ActorOverlay* overlayEntry = actor->overlayEntry;
-            char* actorName = overlayEntry->name != NULL ? overlayEntry->name : "";
+            char* actorName = ActorDB_Retrieve(actor->id)->name;
 
             gDPNoOpString(POLY_OPA_DISP++, actorName, i);
             gDPNoOpString(POLY_XLU_DISP++, actorName, i);
@@ -3053,7 +3032,6 @@ void func_80031C3C(ActorContext* actorCtx, PlayState* play) {
 
     Play_SaveSceneFlags(play);
     func_80030488(play);
-    ActorOverlayTable_Cleanup();
 }
 
 /**
@@ -3110,41 +3088,21 @@ Actor* Actor_RemoveFromCategory(PlayState* play, ActorContext* actorCtx, Actor*
     return newHead;
 }
 
-void Actor_FreeOverlay(ActorOverlay* actorOverlay) {
+void Actor_FreeOverlay(ActorDBEntry* dbEntry) {
     osSyncPrintf(VT_FGCOL(CYAN));
 
-    if (actorOverlay->numLoaded == 0) {
+    if (dbEntry->numLoaded == 0) {
 
-        if (actorOverlay->initInfo->reset != NULL) {
-            actorOverlay->initInfo->reset();
+        if (dbEntry->reset != NULL) {
+            dbEntry->reset();
         }
 
         if (HREG(20) != 0) {
             osSyncPrintf("アクタークライアントが０になりました\n"); // "Actor client is now 0"
         }
-
-        if (actorOverlay->loadedRamAddr != NULL) {
-            if (actorOverlay->allocType & ALLOCTYPE_PERMANENT) {
-                if (HREG(20) != 0) {
-                    osSyncPrintf("オーバーレイ解放しません\n"); // "Overlay will not be deallocated"
-                }
-            } else if (actorOverlay->allocType & ALLOCTYPE_ABSOLUTE) {
-                if (HREG(20) != 0) {
-                    // "Absolute magic field reserved, so deallocation will not occur"
-                    osSyncPrintf("絶対魔法領域確保なので解放しません\n");
-                }
-                actorOverlay->loadedRamAddr = NULL;
-            } else {
-                if (HREG(20) != 0) {
-                    osSyncPrintf("オーバーレイ解放します\n"); // "Overlay deallocated"
-                }
-                ZELDA_ARENA_FREE_DEBUG(actorOverlay->loadedRamAddr);
-                actorOverlay->loadedRamAddr = NULL;
-            }
-        }
     } else if (HREG(20) != 0) {
         // "%d of actor client remains"
-        osSyncPrintf("アクタークライアントはあと %d 残っています\n", actorOverlay->numLoaded);
+        osSyncPrintf("アクタークライアントはあと %d 残っています\n", dbEntry->numLoaded);
     }
 
     osSyncPrintf(VT_RST);
@@ -3163,24 +3121,17 @@ Actor* Actor_Spawn(ActorContext* actorCtx, PlayState* play, s16 actorId, f32 pos
         }
     }
 
-    s32 pad;
     Actor* actor;
-    ActorInit* actorInit;
     s32 objBankIndex;
-    ActorOverlay* overlayEntry;
     u32 temp;
-    char* name;
-    u32 overlaySize;
 
-    overlayEntry = &gActorOverlayTable[actorId];
-    ASSERT(actorId < ACTOR_ID_MAX);
+    ActorDBEntry* dbEntry = ActorDB_Retrieve(actorId);
 
-    name = overlayEntry->name != NULL ? overlayEntry->name : "";
-    overlaySize = (uintptr_t)overlayEntry->vramEnd - (uintptr_t)overlayEntry->vramStart;
+    ASSERT(dbEntry->valid);
 
     if (HREG(20) != 0) {
         // "Actor class addition [%d:%s]"
-        osSyncPrintf("アクタークラス追加 [%d:%s]\n", actorId, name);
+        osSyncPrintf("アクタークラス追加 [%d:%s]\n", actorId, dbEntry->name);
     }
 
     if (actorCtx->total > ACTOR_NUMBER_MAX) {
@@ -3189,112 +3140,55 @@ Actor* Actor_Spawn(ActorContext* actorCtx, PlayState* play, s16 actorId, f32 pos
         return NULL;
     }
 
-    if (overlayEntry->vramStart == 0) {
-        if (HREG(20) != 0) {
-            osSyncPrintf("オーバーレイではありません\n"); // "Not an overlay"
-        }
-
-        actorInit = overlayEntry->initInfo;
-    } else {
-        if (overlayEntry->loadedRamAddr != NULL) {
-            if (HREG(20) != 0) {
-                osSyncPrintf("既にロードされています\n"); // "Already loaded"
-            }
-        } else {
-            if (overlayEntry->allocType & ALLOCTYPE_ABSOLUTE) {
-                ASSERT(overlaySize <= AM_FIELD_SIZE);
-
-                if (actorCtx->absoluteSpace == NULL) {
-                    // "AMF: absolute magic field"
-                    actorCtx->absoluteSpace = ZELDA_ARENA_MALLOC_RDEBUG(AM_FIELD_SIZE);
-                    if (HREG(20) != 0) {
-                        // "Absolute magic field reservation - %d bytes reserved"
-                        osSyncPrintf("絶対魔法領域確保 %d バイト確保\n", AM_FIELD_SIZE);
-                    }
-                }
-
-                overlayEntry->loadedRamAddr = actorCtx->absoluteSpace;
-            } else if (overlayEntry->allocType & ALLOCTYPE_PERMANENT) {
-                overlayEntry->loadedRamAddr = ZELDA_ARENA_MALLOC_RDEBUG(overlaySize);
-            } else {
-                overlayEntry->loadedRamAddr = ZELDA_ARENA_MALLOC_DEBUG(overlaySize);
-            }
-
-            if (overlayEntry->loadedRamAddr == NULL) {
-                // "Cannot reserve actor program memory"
-                osSyncPrintf(VT_COL(RED, WHITE) "Ａｃｔｏｒプログラムメモリが確保できません\n" VT_RST);
-                return NULL;
-            }
-
-            Overlay_Load(overlayEntry->vromStart, overlayEntry->vromEnd, overlayEntry->vramStart, overlayEntry->vramEnd,
-                         overlayEntry->loadedRamAddr);
-
-            osSyncPrintf(VT_FGCOL(GREEN));
-            osSyncPrintf("OVL(a):Seg:%08x-%08x Ram:%08x-%08x Off:%08x %s\n", overlayEntry->vramStart,
-                         overlayEntry->vramEnd, overlayEntry->loadedRamAddr,
-                         (uintptr_t)overlayEntry->loadedRamAddr + (uintptr_t)overlayEntry->vramEnd - (uintptr_t)overlayEntry->vramStart,
-                         (uintptr_t)overlayEntry->vramStart - (uintptr_t)overlayEntry->loadedRamAddr, name);
-            osSyncPrintf(VT_RST);
-
-            overlayEntry->numLoaded = 0;
-        }
-
-        actorInit = (void*)(uintptr_t)((overlayEntry->initInfo != NULL)
-                                     ? (void*)((uintptr_t)overlayEntry->initInfo -
-                                               ((intptr_t)overlayEntry->vramStart - (intptr_t)overlayEntry->loadedRamAddr))
-                                     : NULL);
-    }
-
-    objBankIndex = Object_GetIndex(&play->objectCtx, actorInit->objectId);
+    objBankIndex = Object_GetIndex(&gPlayState->objectCtx, dbEntry->objectId);
 
     if (objBankIndex < 0 && (!gMapLoading || CVarGetInteger("gRandomizedEnemies", 0))) {
         objBankIndex = 0;
     }
 
     if ((objBankIndex < 0) ||
-        ((actorInit->category == ACTORCAT_ENEMY) && Flags_GetClear(play, play->roomCtx.curRoom.num))) {
+        ((dbEntry->category == ACTORCAT_ENEMY) && Flags_GetClear(play, play->roomCtx.curRoom.num))) {
         // "No data bank!! <data bank＝%d> (profilep->bank=%d)"
         osSyncPrintf(VT_COL(RED, WHITE) "データバンク無し！！<データバンク＝%d>(profilep->bank=%d)\n" VT_RST,
-                     objBankIndex, actorInit->objectId);
-        Actor_FreeOverlay(overlayEntry);
+                     objBankIndex, dbEntry->objectId);
+        Actor_FreeOverlay(dbEntry);
         return NULL;
     }
 
-    actor = ZELDA_ARENA_MALLOC_DEBUG(actorInit->instanceSize);
+    actor = ZELDA_ARENA_MALLOC_DEBUG(dbEntry->instanceSize);
 
     if (actor == NULL) {
         // "Actor class cannot be reserved! %s <size＝%d bytes>"
-        osSyncPrintf(VT_COL(RED, WHITE) "Ａｃｔｏｒクラス確保できません！ %s <サイズ＝%dバイト>\n", VT_RST, name,
-                     actorInit->instanceSize);
-        Actor_FreeOverlay(overlayEntry);
+        osSyncPrintf(VT_COL(RED, WHITE) "Ａｃｔｏｒクラス確保できません！ %s <サイズ＝%dバイト>\n", VT_RST,
+                     dbEntry->name, dbEntry->instanceSize);
+        Actor_FreeOverlay(dbEntry);
         return NULL;
     }
 
-    ASSERT(overlayEntry->numLoaded < 255);
+    ASSERT(dbEntry->numLoaded < 255);
 
-    overlayEntry->numLoaded++;
+    dbEntry->numLoaded++;
 
     if (HREG(20) != 0) {
         // "Actor client No. %d"
-        osSyncPrintf("アクタークライアントは %d 個目です\n", overlayEntry->numLoaded);
+        osSyncPrintf("アクタークライアントは %d 個目です\n", dbEntry->numLoaded);
     }
 
-    memset((u8*)actor, 0, actorInit->instanceSize);
-    actor->overlayEntry = overlayEntry;
-    actor->id = actorInit->id;
-    actor->flags = actorInit->flags;
+    memset((u8*)actor, 0, dbEntry->instanceSize);
+    actor->id = dbEntry->id;
+    actor->flags = dbEntry->flags;
 
-    if (actorInit->id == ACTOR_EN_PART) {
+    if (dbEntry->id == ACTOR_EN_PART) {
         actor->objBankIndex = rotZ;
         rotZ = 0;
     } else {
         actor->objBankIndex = objBankIndex;
     }
 
-    actor->init = actorInit->init;
-    actor->destroy = actorInit->destroy;
-    actor->update = actorInit->update;
-    actor->draw = actorInit->draw;
+    actor->init = dbEntry->init;
+    actor->destroy = dbEntry->destroy;
+    actor->update = dbEntry->update;
+    actor->draw = dbEntry->draw;
     actor->room = play->roomCtx.curRoom.num;
     actor->home.pos.x = posX;
     actor->home.pos.y = posY;
@@ -3304,7 +3198,7 @@ Actor* Actor_Spawn(ActorContext* actorCtx, PlayState* play, s16 actorId, f32 pos
     actor->home.rot.z = rotZ;
     actor->params = params;
 
-    Actor_AddToCategory(actorCtx, actor, actorInit->category);
+    Actor_AddToCategory(actorCtx, actor, dbEntry->category);
 
     temp = gSegments[6];
     Actor_Init(actor, play);
@@ -3378,18 +3272,16 @@ Actor* Actor_SpawnEntry(ActorContext* actorCtx, ActorEntry* actorEntry, PlayStat
 }
 
 Actor* Actor_Delete(ActorContext* actorCtx, Actor* actor, PlayState* play) {
-    char* name;
     Player* player;
     Actor* newHead;
-    ActorOverlay* overlayEntry;
+    ActorDBEntry* dbEntry;
 
     player = GET_PLAYER(play);
 
-    overlayEntry = actor->overlayEntry;
-    name = overlayEntry->name != NULL ? overlayEntry->name : "";
+    dbEntry = ActorDB_Retrieve(actor->id);
 
     if (HREG(20) != 0) {
-        osSyncPrintf("アクタークラス削除 [%s]\n", name); // "Actor class deleted [%s]"
+        osSyncPrintf("アクタークラス削除 [%s]\n", dbEntry->name); // "Actor class deleted [%s]"
     }
 
     if ((player != NULL) && (actor == player->unk_664)) {
@@ -3416,16 +3308,8 @@ Actor* Actor_Delete(ActorContext* actorCtx, Actor* actor, PlayState* play) {
 
     ZELDA_ARENA_FREE_DEBUG(actor);
 
-    /* if (overlayEntry->vramStart == 0) {
-        if (HREG(20) != 0) {
-            osSyncPrintf("オーバーレイではありません\n"); // "Not an overlay"
-        }
-    } else { */
-        //ASSERT(overlayEntry->loadedRamAddr != NULL, "actor_dlftbl->allocp != NULL");
-        //ASSERT(overlayEntry->numLoaded > 0, "actor_dlftbl->clients > 0");
-        overlayEntry->numLoaded--;
-        Actor_FreeOverlay(overlayEntry);
-    //}
+    dbEntry->numLoaded--;
+    Actor_FreeOverlay(dbEntry);
 
     return newHead;
 }
diff --git a/soh/src/code/z_actor_dlftbls.c b/soh/src/code/z_actor_dlftbls.c
deleted file mode 100644
index ee18d9703..000000000
--- a/soh/src/code/z_actor_dlftbls.c
+++ /dev/null
@@ -1,97 +0,0 @@
-#include "global.h"
-
-// Linker symbol declarations (used in the table below)
-#define DEFINE_ACTOR(name, _1, _2) DECLARE_OVERLAY_SEGMENT(name)
-#define DEFINE_ACTOR_INTERNAL(_0, _1, _2)
-#define DEFINE_ACTOR_UNSET(_0)
-
-#include "tables/actor_table.h"
-
-#undef DEFINE_ACTOR
-#undef DEFINE_ACTOR_INTERNAL
-#undef DEFINE_ACTOR_UNSET
-
-// Init Vars declarations (also used in the table below)
-#define DEFINE_ACTOR(name, _1, _2) extern ActorInit name##_InitVars;
-#define DEFINE_ACTOR_INTERNAL(name, _1, _2) extern ActorInit name##_InitVars;
-#define DEFINE_ACTOR_UNSET(_0)
-
-#include "tables/actor_table.h"
-
-#undef DEFINE_ACTOR
-#undef DEFINE_ACTOR_INTERNAL
-#undef DEFINE_ACTOR_UNSET
-
-// Actor Overlay Table definition
-//#define DEFINE_ACTOR(name, _1, allocType) \
-//    { (uintptr_t)_ovl_##name##SegmentRomStart,  \
-//      (uintptr_t)_ovl_##name##SegmentRomEnd,    \
-//      _ovl_##name##SegmentStart,          \
-//      _ovl_##name##SegmentEnd,            \
-//      NULL,                               \
-//      &name##_InitVars,                   \
-//      #name,                              \
-//      allocType,                          \
-//      0 },
-
-#define DEFINE_ACTOR_INTERNAL(name, _1, allocType) { 0, 0, NULL, NULL, NULL, &name##_InitVars, #name, allocType, 0 },
-
-#define DEFINE_ACTOR_UNSET(_0) { 0 },
-
-#define DEFINE_ACTOR(name, _1, allocType) { 0, 0, NULL, NULL, NULL, &name##_InitVars, #name, allocType, 0 },
-
-ActorOverlay gActorOverlayTable[] = {
-#include "tables/actor_table.h"
-};
-
-#undef DEFINE_ACTOR
-#undef DEFINE_ACTOR_INTERNAL
-#undef DEFINE_ACTOR_UNSET
-
-s32 gMaxActorId = 0;
-
-static FaultClient sFaultClient;
-
-void ActorOverlayTable_LogPrint(void) {
-    ActorOverlay* overlayEntry;
-    u32 i;
-
-    osSyncPrintf("actor_dlftbls %u\n", gMaxActorId);
-    osSyncPrintf("RomStart RomEnd   SegStart SegEnd   allocp   profile  segname\n");
-
-    for (i = 0, overlayEntry = &gActorOverlayTable[0]; i < (u32)gMaxActorId; i++, overlayEntry++) {
-        osSyncPrintf("%08x %08x %08x %08x %08x %08x %s\n", overlayEntry->vromStart, overlayEntry->vromEnd,
-                     overlayEntry->vramStart, overlayEntry->vramEnd, overlayEntry->loadedRamAddr,
-                     &overlayEntry->initInfo->id, overlayEntry->name != NULL ? overlayEntry->name : "?");
-    }
-}
-
-void ActorOverlayTable_FaultPrint(void* arg0, void* arg1) {
-    ActorOverlay* overlayEntry;
-    u32 overlaySize;
-    s32 i;
-
-    FaultDrawer_SetCharPad(-2, 0);
-
-    FaultDrawer_Printf("actor_dlftbls %u\n", gMaxActorId);
-    FaultDrawer_Printf("No. RamStart- RamEnd cn  Name\n");
-
-    for (i = 0, overlayEntry = &gActorOverlayTable[0]; i < gMaxActorId; i++, overlayEntry++) {
-        overlaySize = (uintptr_t)overlayEntry->vramEnd - (uintptr_t)overlayEntry->vramStart;
-        if (overlayEntry->loadedRamAddr != NULL) {
-            FaultDrawer_Printf("%3d %08x-%08x %3d %s\n", i, overlayEntry->loadedRamAddr,
-                               (uintptr_t)overlayEntry->loadedRamAddr + overlaySize, overlayEntry->numLoaded,
-                               overlayEntry->name != NULL ? overlayEntry->name : "");
-        }
-    }
-}
-
-void ActorOverlayTable_Init(void) {
-    gMaxActorId = ACTOR_ID_MAX;
-    Fault_AddClient(&sFaultClient, ActorOverlayTable_FaultPrint, NULL, NULL);
-}
-
-void ActorOverlayTable_Cleanup(void) {
-    Fault_RemoveClient(&sFaultClient);
-    gMaxActorId = 0;
-}
diff --git a/soh/src/code/z_play.c b/soh/src/code/z_play.c
index 8c5ebb950..44e5442db 100644
--- a/soh/src/code/z_play.c
+++ b/soh/src/code/z_play.c
@@ -29,6 +29,8 @@ u64 D_801614D0[0xA00];
 
 PlayState* gPlayState;
 
+s16 gEnPartnerId;
+
 void func_800BC450(PlayState* play) {
     Camera_ChangeDataIdx(GET_ACTIVE_CAM(play), play->unk_1242B - 1);
 }
@@ -729,7 +731,7 @@ void Play_Init(GameState* thisx) {
     #endif
 
     if (CVarGetInteger("gIvanCoopModeEnabled", 0)) {
-        Actor_Spawn(&play->actorCtx, play, ACTOR_EN_PARTNER, GET_PLAYER(play)->actor.world.pos.x,
+        Actor_Spawn(&play->actorCtx, play, gEnPartnerId, GET_PLAYER(play)->actor.world.pos.x,
                     GET_PLAYER(play)->actor.world.pos.y + Player_GetHeight(GET_PLAYER(play)) + 5.0f,
                     GET_PLAYER(play)->actor.world.pos.z, 0, 0, 0, 1, true);
     }
@@ -764,7 +766,6 @@ void Play_Update(PlayState* play) {
 
     if ((HREG(81) == 18) && (HREG(82) < 0)) {
         HREG(82) = 0;
-        ActorOverlayTable_LogPrint();
     }
 
     if (CVarGetInteger("gFreeCamera", 0) && Player_InCsMode(play)) {
diff --git a/soh/src/code/z_scene.c b/soh/src/code/z_scene.c
index d975c08ab..63529e199 100644
--- a/soh/src/code/z_scene.c
+++ b/soh/src/code/z_scene.c
@@ -1,5 +1,6 @@
 #include "global.h"
 #include "vt.h"
+#include "soh/ActorDB.h"
 
 RomFile sNaviMsgFiles[];
 
@@ -193,7 +194,7 @@ void Scene_CommandSpawnList(PlayState* play, SceneCmd* cmd) {
 
     linkObjectId = gLinkObjectIds[((void)0, gSaveContext.linkAge)];
 
-    gActorOverlayTable[linkEntry->id].initInfo->objectId = linkObjectId;
+    ActorDB_Retrieve(linkEntry->id)->objectId = linkObjectId;
     Object_Spawn(&play->objectCtx, linkObjectId);
 }