ZRoom refactor (#124)

* Remove redundant methods

* first pass os cleaning

* More cleaning

* Fix compilation errors

* Fix dumb crashes

* Fix dumb issues

* Removing most uses of GenerateSourceCodePass1

* more cleanup

* Move segmentOffset to ZRoomCommand

* Half of ParseRawData

* somehow broken...

* fix broken stuff

* This may or may not be broken

* More cleaning

* Remove GenerateSourceCodePass2

* More cleanup and pointer removal

* Use PolygonType2 in SetMesh

* another small cleanup

* Merge PolygonDlist and PolygonDlist2

* More code merging

* GetDeclarationPtrName

* Remove most repeated externs and a bit of redundant code

* Dumb MM fixes

* small fix

(cherry picked from commit 0813fd69538491c5aceb00d79d19bf59fd082ca7)

* Another dumb fix

* Remove GenerateExterns

* Change DeclareReferences signature

* Refactor SetAnimatedTextureList

* const std::vector<uint8_t>&

* another small bunch of changes

* last parserawdata and declarereferences separation probably

* Move parserawdata

* Remove GenerateSourceCodePass1

* Use macros for commands

* Make ZRoomCommand inherit  ZResource

* shrink scenes tluts

* ProcessTextureIntersections

* small output improvements

* Small changes

* run format

* SCENE_CMD -> SCENECMD

* fix merge errors

* run format

* fix some warnings

* update macros names

* Add again different commands for each game ni SCENE_CMD_ROOM_BEHAVIOR

* macro update

* More booleans

* Move declaration to its own file

* minor changes

* Update according to latest reviews in oot

* run format

* Yet another cutscene change

* Remove special scene/room segment code

* This is crashing and I don't know why

* remove includeFilePrefix

* fix merge issues

* always pass a parent to zresource

* move path to its own zclass and properly implement parserawdata in commands

* Fix GetDeclarationPtrName uses

* Some ZPath fixes (still broken tho)

* Fix ZPath declarations

* Fix weird problem

* Add `Path` to the docs

* run format

* clean syotes code

* A bunch of changes for MM

* run format

1 files changed, 16 insertions, 13 deletions

diff --git a/ZAPD/ZRoom/Commands/SetSkyboxModifier.cpp b/ZAPD/ZRoom/Commands/SetSkyboxModifier.cpp
index 612d289..d8af2d1 100644
--- a/ZAPD/ZRoom/Commands/SetSkyboxModifier.cpp
+++ b/ZAPD/ZRoom/Commands/SetSkyboxModifier.cpp
@@ -1,21 +1,24 @@
 #include "SetSkyboxModifier.h"
-#include "../../StringHelper.h"
 
-SetSkyboxModifier::SetSkyboxModifier(ZRoom* nZRoom, std::vector<uint8_t> rawData,
-                                     uint32_t rawDataIndex)
-	: ZRoomCommand(nZRoom, rawData, rawDataIndex)
+#include "StringHelper.h"
+
+SetSkyboxModifier::SetSkyboxModifier(ZFile* nParent) : ZRoomCommand(nParent)
 {
-	disableSky = rawData[rawDataIndex + 0x04];
-	disableSunMoon = rawData[rawDataIndex + 0x05];
 }
 
-std::string SetSkyboxModifier::GenerateSourceCodePass1(std::string roomName, uint32_t baseAddress)
+void SetSkyboxModifier::ParseRawData()
 {
-	return StringHelper::Sprintf(
-		"%s 0, 0, 0, 0x%02X, 0x%02X",
-		ZRoomCommand::GenerateSourceCodePass1(roomName, baseAddress).c_str(), disableSky,
-		disableSunMoon);
-	;
+	ZRoomCommand::ParseRawData();
+	disableSky = parent->GetRawData().at(rawDataIndex + 0x04);
+	disableSunMoon = parent->GetRawData().at(rawDataIndex + 0x05);
+}
+
+std::string SetSkyboxModifier::GetBodySourceCode() const
+{
+	std::string sky = StringHelper::BoolStr(disableSky);
+	std::string soonMoon = StringHelper::BoolStr(disableSunMoon);
+	return StringHelper::Sprintf("SCENE_CMD_SKYBOX_DISABLES(%s, %s)", sky.c_str(),
+	                             soonMoon.c_str());
 }
 
 std::string SetSkyboxModifier::GetCommandCName() const
@@ -26,4 +29,4 @@ std::string SetSkyboxModifier::GetCommandCName() const
 RoomCommand SetSkyboxModifier::GetRoomCommand() const
 {
 	return RoomCommand::SetSkyboxModifier;
-}
\ No newline at end of file
+}