Fix out-of-bounds reading when converting textures to C (#236)

* Fill buffer to a multiple of 8 bytes

* Remove overloaded bitconverter methods and use boundary-checker .at method when possible

* Add  a warning in oob reads in the  bitconverter

* Remove repeated code

* format

* Whoops

* whoops++

1 files changed, 9 insertions, 9 deletions

diff --git a/ZAPD/ZTexture.h b/ZAPD/ZTexture.h
index 29c3fbc..6f2c499 100644
--- a/ZAPD/ZTexture.h
+++ b/ZAPD/ZTexture.h
@@ -40,15 +40,15 @@ protected:
 	void PrepareBitmapPalette8();
 
 	void PrepareRawDataFromFile(const fs::path& inFolder);
-	void PrepareRawDataRGBA16(const fs::path& rgbaPath);
-	void PrepareRawDataRGBA32(const fs::path& rgbaPath);
-	void PrepareRawDataGrayscale4(const fs::path& grayPath);
-	void PrepareRawDataGrayscale8(const fs::path& grayPath);
-	void PrepareRawDataGrayscaleAlpha4(const fs::path& grayAlphaPath);
-	void PrepareRawDataGrayscaleAlpha8(const fs::path& grayAlphaPath);
-	void PrepareRawDataGrayscaleAlpha16(const fs::path& grayAlphaPath);
-	void PrepareRawDataPalette4(const fs::path& palPath);
-	void PrepareRawDataPalette8(const fs::path& palPath);
+	void PrepareRawDataRGBA16();
+	void PrepareRawDataRGBA32();
+	void PrepareRawDataGrayscale4();
+	void PrepareRawDataGrayscale8();
+	void PrepareRawDataGrayscaleAlpha4();
+	void PrepareRawDataGrayscaleAlpha8();
+	void PrepareRawDataGrayscaleAlpha16();
+	void PrepareRawDataPalette4();
+	void PrepareRawDataPalette8();
 
 public:
 	ZTexture(ZFile* nParent);