diff options
| author | Léo Lam <leo@leolam.fr> | 2021-12-31 19:24:15 +0100 |
|---|---|---|
| committer | Léo Lam <leo@leolam.fr> | 2021-12-31 19:24:15 +0100 |
| commit | b4f29aa59cd57040671744e70c353f2001ae02fe (patch) | |
| tree | 45485d883f9c3c78f4fe7f68d6f563578e9d0c99 | |
| parent | f74f3046e23fae5ea44c32bc8b435ef65171295b (diff) | |
contributing: Drop #ifdef NON_MATCHING requirement
| -rw-r--r-- | Contributing.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Contributing.md b/Contributing.md index eb5394b3..92a05a82 100644 --- a/Contributing.md +++ b/Contributing.md @@ -99,7 +99,7 @@ CLion interacts with CMake directly, so you need to make sure CLion's build prof 8. **Update the list of decompiled functions**. * If you have a function that matches perfectly, great! - * If there are still minor differences left, wrap the function in an `#ifdef NON_MATCHING`, add a comment to explain what is wrong, and change the status (the second column) to `m` (minor difference) in the CSV. + * If there are still minor differences left, write a comment to explain what is wrong (if you think that is necessary), and change the status (the second column) to `m` (minor difference) in the CSV. * For major differences (lots of entirely red/green/blue lines in the diff), use a capital `M` (major difference) in place of `m`. 9. Before opening a PR, reformat the code with clang-format and run `tools/check`. |