diff options
| author | Léo Lam <leo@leolam.fr> | 2022-02-27 12:48:28 +0100 |
|---|---|---|
| committer | Léo Lam <leo@leolam.fr> | 2022-02-27 12:50:52 +0100 |
| commit | df36d656650198b3cbf140e2982752a95b3f2c6d (patch) | |
| tree | 1af53905980b13aa03ab2f78dd548407370eb98c /src/KingSystem/Utils/Thread/Task.cpp | |
| parent | a5641860025aed373da045ef1ac43a6487529932 (diff) | |
Revert "Add #ifdef declarations for NON_MATCHING code"
This reverts commit 42807160cfb33af9f3cf2fa6b0ba98f232208cdb.
It makes searching for NON_MATCHING comment descriptions much less
convenient in most text editors or IDEs, and we want the function
CSV to be the single source of truth for function statuses. Having
a function marked as matching but not built because of a stray #ifdef
would be bad.
Diffstat (limited to 'src/KingSystem/Utils/Thread/Task.cpp')
| -rw-r--r-- | src/KingSystem/Utils/Thread/Task.cpp | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/src/KingSystem/Utils/Thread/Task.cpp b/src/KingSystem/Utils/Thread/Task.cpp index 71cf18f5..e2ba464f 100644 --- a/src/KingSystem/Utils/Thread/Task.cpp +++ b/src/KingSystem/Utils/Thread/Task.cpp @@ -34,8 +34,7 @@ void Task::deleteDelegate_() { } } -// mDelegate2 = nullptr store -#ifdef NON_MATCHING +// NON_MATCHING: mDelegate2 = nullptr store void Task::finalize_() { if (mStatus == Status::Finalized) return; @@ -48,7 +47,6 @@ void Task::finalize_() { mRemoveCallback = nullptr; mStatus = Status::Finalized; } -#endif bool Task::setDelegate(const TaskDelegateSetter& setter) { mDelegate = setter.getDelegate(); @@ -58,8 +56,7 @@ bool Task::setDelegate(const TaskDelegateSetter& setter) { return onSetDelegate_(setter); } -// branching -#ifdef NON_MATCHING +// NON_MATCHING: branching bool Task::submitRequest(TaskRequest& request) { // Processing this request is impossible if there is no thread *and* no queue! if (request.mThread == nullptr && request.mQueue == nullptr) @@ -117,7 +114,6 @@ bool Task::submitRequest(TaskRequest& request) { } return push_ok || b; } -#endif bool Task::canSubmitRequest() const { const bool run_finished_on_current_thread = |