summaryrefslogtreecommitdiff
path: root/src/KingSystem/Utils/Thread/TaskQueueBase.cpp
diff options
context:
space:
mode:
authorLéo Lam <leo@leolam.fr>2022-02-27 12:48:28 +0100
committerLéo Lam <leo@leolam.fr>2022-02-27 12:50:52 +0100
commitdf36d656650198b3cbf140e2982752a95b3f2c6d (patch)
tree1af53905980b13aa03ab2f78dd548407370eb98c /src/KingSystem/Utils/Thread/TaskQueueBase.cpp
parenta5641860025aed373da045ef1ac43a6487529932 (diff)
Revert "Add #ifdef declarations for NON_MATCHING code"
This reverts commit 42807160cfb33af9f3cf2fa6b0ba98f232208cdb. It makes searching for NON_MATCHING comment descriptions much less convenient in most text editors or IDEs, and we want the function CSV to be the single source of truth for function statuses. Having a function marked as matching but not built because of a stray #ifdef would be bad.
Diffstat (limited to 'src/KingSystem/Utils/Thread/TaskQueueBase.cpp')
-rw-r--r--src/KingSystem/Utils/Thread/TaskQueueBase.cpp8
1 files changed, 2 insertions, 6 deletions
diff --git a/src/KingSystem/Utils/Thread/TaskQueueBase.cpp b/src/KingSystem/Utils/Thread/TaskQueueBase.cpp
index 8c220ebb..49e91f24 100644
--- a/src/KingSystem/Utils/Thread/TaskQueueBase.cpp
+++ b/src/KingSystem/Utils/Thread/TaskQueueBase.cpp
@@ -234,8 +234,7 @@ void TaskQueueBase::blockTasks(u8 id) {
mLanes[id].blocked = true;
}
-// the while (!areAllThreadsPaused()) loop generates weird code in the original
-#ifdef NON_MATCHING
+// NON_MATCHING: the while (!areAllThreadsPaused()) loop generates weird code in the original
void TaskQueueBase::blockTasksAndReloadThreads(u8 id) {
blockTasks(id);
@@ -258,7 +257,6 @@ void TaskQueueBase::blockTasksAndReloadThreads(u8 id) {
thread.resume();
}
}
-#endif
void TaskQueueBase::unblockTasks(u8 id) {
if (mLanes[id].blocked) {
@@ -409,8 +407,7 @@ void TaskQueueBase::removeTask(Task* task, bool b) {
unlock();
}
-// regalloc inside the task lambda + reorderings for the loop counters.
-#ifdef NON_MATCHING
+// NON_MATCHING: regalloc inside the task lambda + reorderings for the loop counters.
void TaskQueueBase::fetchTask(Task** out_task) {
lock();
@@ -484,6 +481,5 @@ void TaskQueueBase::fetchTask(Task** out_task) {
unlock();
}
-#endif
} // namespace ksys::util