diff options
| author | Léo Lam <leo@leolam.fr> | 2022-02-27 12:48:28 +0100 |
|---|---|---|
| committer | Léo Lam <leo@leolam.fr> | 2022-02-27 12:50:52 +0100 |
| commit | df36d656650198b3cbf140e2982752a95b3f2c6d (patch) | |
| tree | 1af53905980b13aa03ab2f78dd548407370eb98c /src/KingSystem/Utils/Thread/TaskThread.cpp | |
| parent | a5641860025aed373da045ef1ac43a6487529932 (diff) | |
Revert "Add #ifdef declarations for NON_MATCHING code"
This reverts commit 42807160cfb33af9f3cf2fa6b0ba98f232208cdb.
It makes searching for NON_MATCHING comment descriptions much less
convenient in most text editors or IDEs, and we want the function
CSV to be the single source of truth for function statuses. Having
a function marked as matching but not built because of a stray #ifdef
would be bad.
Diffstat (limited to 'src/KingSystem/Utils/Thread/TaskThread.cpp')
| -rw-r--r-- | src/KingSystem/Utils/Thread/TaskThread.cpp | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/KingSystem/Utils/Thread/TaskThread.cpp b/src/KingSystem/Utils/Thread/TaskThread.cpp index be24952b..27dcd4e9 100644 --- a/src/KingSystem/Utils/Thread/TaskThread.cpp +++ b/src/KingSystem/Utils/Thread/TaskThread.cpp @@ -136,9 +136,8 @@ bool TaskThread::isLookingForTask() const { return mFlags.isOn(Flag::IsLookingForTask); } -// branching for `if (mTaskQueue->getNumActiveTasks() == 0)`: +// NON_MATCHING: branching for `if (mTaskQueue->getNumActiveTasks() == 0)`: // Clang got rid of the branch and merged the two mFlags writes -#ifdef NON_MATCHING void TaskThread::calc_(sead::MessageQueue::Element msg) { if (mFlags.isOn(Flag::Paused)) { if (msg != cMessage_Resume) @@ -240,7 +239,6 @@ void TaskThread::calc_(sead::MessageQueue::Element msg) { mFlags.reset(Flag::IsActive); mFlags.reset(Flag::IsLookingForTask); } -#endif bool TaskThread::receivedPauseMsg() const { return mMessageQueue.peek(sead::MessageQueue::BlockType::NonBlocking) == cMessage_Pause; |