diff options
| author | Léo Lam <leo@leolam.fr> | 2021-04-06 01:41:55 +0200 |
|---|---|---|
| committer | Léo Lam <leo@leolam.fr> | 2021-04-06 18:25:29 +0200 |
| commit | 49edd5f482036dec2fa0778366e2c4ea118d89a5 (patch) | |
| tree | a9ed99a4f566adfd2bc5e6bf4b6e517bb17b68b3 | |
| parent | 960d957f4fe5430eece3d99fc0d4d5649e848f64 (diff) | |
MMU: Remove a bunch of useless swaps
The swaps are confusing and don't accomplish much.
It was originally written like this:
u32 pte = bswap(*(u32*)&base_mem[pteg_addr]);
then bswap was changed to Common::swap32, and then the array access
was replaced with Memory::Read_U32, leading to the useless swaps.
| -rw-r--r-- | Source/Core/Core/PowerPC/MMU.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/Source/Core/Core/PowerPC/MMU.cpp b/Source/Core/Core/PowerPC/MMU.cpp index a8ed456de7..3adf10a294 100644 --- a/Source/Core/Core/PowerPC/MMU.cpp +++ b/Source/Core/Core/PowerPC/MMU.cpp @@ -1113,7 +1113,7 @@ static TranslateAddressResult TranslatePageAddress(const u32 address, const XChe // hash function no 1 "xor" .360 u32 hash = (VSID ^ page_index); - u32 pte1 = Common::swap32((VSID << 7) | api | PTE1_V); + u32 pte1 = (VSID << 7) | api | PTE1_V; for (int hash_func = 0; hash_func < 2; hash_func++) { @@ -1121,7 +1121,7 @@ static TranslateAddressResult TranslatePageAddress(const u32 address, const XChe if (hash_func == 1) { hash = ~hash; - pte1 |= PTE1_H << 24; + pte1 |= PTE1_H; } u32 pteg_addr = @@ -1129,7 +1129,7 @@ static TranslateAddressResult TranslatePageAddress(const u32 address, const XChe for (int i = 0; i < 8; i++, pteg_addr += 8) { - u32 pteg = Common::swap32(Memory::Read_U32(pteg_addr)); + const u32 pteg = Memory::Read_U32(pteg_addr); if (pte1 == pteg) { |