Merge pull request #14582 from jordan-woyak/gamesettings-allow-imm-xfb

 GameSettings: Allow ImmediateXFB for a handful of games that seem fine with it.

14 files changed, 3 insertions, 178 deletions

diff --git a/Data/Sys/GameSettings/G6S.ini b/Data/Sys/GameSettings/G6S.ini
index b4d39150b3..c0295acb8a 100644
--- a/Data/Sys/GameSettings/G6S.ini
+++ b/Data/Sys/GameSettings/G6S.ini
@@ -1,18 +1,8 @@
 # G6SE7D, G6SP7D - The Legend of Spyro: A New Beginning
 
-[Core]
-# Values set here will override the main Dolphin settings.
-
-[OnFrame]
-# Add memory patches to be applied every frame here.
-
-[ActionReplay]
-# Add action replay cheats here.
-
 [Video_Settings]
 SafeTextureCacheColorSamples = 512
 
 [Video_Hacks]
-ImmediateXFBEnable = False
 # Fixes missing splash logo at boot.
 EFBAccessEnable = True
diff --git a/Data/Sys/GameSettings/GCP.ini b/Data/Sys/GameSettings/GCP.ini
deleted file mode 100644
index b3d6c71dfc..0000000000
--- a/Data/Sys/GameSettings/GCP.ini
+++ /dev/null
@@ -1,15 +0,0 @@
-# GCPE6S, GCPP6S - CASPER
-
-[Core]
-# Values set here will override the main Dolphin settings.
-
-[OnFrame]
-# Add memory patches to be applied every frame here.
-
-[ActionReplay]
-# Add action replay cheats here.
-
-[Video_Settings]
-
-[Video_Hacks]
-ImmediateXFBEnable = False
diff --git a/Data/Sys/GameSettings/GFO.ini b/Data/Sys/GameSettings/GFO.ini
index 2fcc3cd213..48f07e9e5f 100644
--- a/Data/Sys/GameSettings/GFO.ini
+++ b/Data/Sys/GameSettings/GFO.ini
@@ -1,17 +1,5 @@
 # GFOE78, GFOP78 - The Fairly OddParents: Shadow Showdown
 
-[Core]
-# Values set here will override the main Dolphin settings.
-
-[OnFrame]
-# Add memory patches to be applied every frame here.
-
-[ActionReplay]
-# Add action replay cheats here.
-
 [Video_Settings]
 # Needed for some FMVs.
 SafeTextureCacheColorSamples = 512
-
-[Video_Hacks]
-ImmediateXFBEnable = False
diff --git a/Data/Sys/GameSettings/GFW.ini b/Data/Sys/GameSettings/GFW.ini
index 011c8058e4..0743dcd017 100644
--- a/Data/Sys/GameSettings/GFW.ini
+++ b/Data/Sys/GameSettings/GFW.ini
@@ -1,17 +1,5 @@
 # GFWE78 - The Fairly OddParents: Breakin' Da Rules
 
-[Core]
-# Values set here will override the main Dolphin settings.
-
-[OnFrame]
-# Add memory patches to be applied every frame here.
-
-[ActionReplay]
-# Add action replay cheats here.
-
 [Video_Settings]
 # Needed for some FMVs.
 SafeTextureCacheColorSamples = 512
-
-[Video_Hacks]
-ImmediateXFBEnable = False
diff --git a/Data/Sys/GameSettings/GHQ.ini b/Data/Sys/GameSettings/GHQ.ini
deleted file mode 100644
index fd24a3a8d1..0000000000
--- a/Data/Sys/GameSettings/GHQ.ini
+++ /dev/null
@@ -1,15 +0,0 @@
-# GHQE7D, GHQP7D - The Simpsons: Hit & Run
-
-[Core]
-# Values set here will override the main Dolphin settings.
-
-[OnFrame]
-# Add memory patches to be applied every frame here.
-
-[ActionReplay]
-# Add action replay cheats here.
-
-[Video_Settings]
-
-[Video_Hacks]
-ImmediateXFBEnable = False
diff --git a/Data/Sys/GameSettings/GKB.ini b/Data/Sys/GameSettings/GKB.ini
index 783ca7a69f..0a6b4f9019 100644
--- a/Data/Sys/GameSettings/GKB.ini
+++ b/Data/Sys/GameSettings/GKB.ini
@@ -1,17 +1,10 @@
-# GKBEAF, GKBJAF, GKBPAF - Baten Kaitos Eternal Wings and the Lost Ocean
+# GKBEAF, GKBJAF, GKBPAF - Baten Kaitos: Eternal Wings and the Lost Ocean
 
 [Core]
 # This game will crash when shopping with certain items in inventory
 # unless Single Core is enabled.
 CPUThread = False
 
-
-[OnFrame]
-# Add memory patches to be applied every frame here.
-
-[ActionReplay]
-# Add action replay cheats here.
-
 [Gecko]
 $16:9 Widescreen Region-Free
 F6000001 80008180
@@ -61,8 +54,8 @@ D003000C 38800001
 E0000000 80008000
 
 [Video_Hacks]
-ImmediateXFBEnable = False
 EFBToTextureEnable = False
+# Avoids random crashes after a fight against Kalas late in the game.
 DeferEFBCopies = False
 
 [Gecko_RetroAchievements_Verified]
diff --git a/Data/Sys/GameSettings/GRK.ini b/Data/Sys/GameSettings/GRK.ini
index 6e59528829..c23c002635 100644
--- a/Data/Sys/GameSettings/GRK.ini
+++ b/Data/Sys/GameSettings/GRK.ini
@@ -1,17 +1,4 @@
 # GRKE41, GRKP7G - Rocky
 
-[Core]
-# Values set here will override the main Dolphin settings.
-
-[OnFrame]
-# Add memory patches to be applied every frame here.
-
-[ActionReplay]
-# Add action replay cheats here.
-
 [Video_Settings]
 SafeTextureCacheColorSamples = 512
-
-[Video_Hacks]
-ImmediateXFBEnable = False
-
diff --git a/Data/Sys/GameSettings/GTW.ini b/Data/Sys/GameSettings/GTW.ini
deleted file mode 100644
index 2047e82689..0000000000
--- a/Data/Sys/GameSettings/GTW.ini
+++ /dev/null
@@ -1,16 +0,0 @@
-# GTWE70, GTWP70 - Taz Wanted
-
-[Core]
-# Values set here will override the main Dolphin settings.
-
-[OnFrame]
-# Add memory patches to be applied every frame here.
-
-[ActionReplay]
-# Add action replay cheats here.
-
-[Video_Settings]
-
-[Video_Hacks]
-ImmediateXFBEnable = False
-
diff --git a/Data/Sys/GameSettings/GWL.ini b/Data/Sys/GameSettings/GWL.ini
index 42b41ba9a5..8df837fb68 100644
--- a/Data/Sys/GameSettings/GWL.ini
+++ b/Data/Sys/GameSettings/GWL.ini
@@ -1,14 +1,4 @@
-# GWLE6L, GWLX6L - Project Zoo
+# GWLE6L, GWLX6L - Wallace & Gromit in Project Zoo
 
 [Core]
-# Values set here will override the main Dolphin settings.
 MemoryCardSize = 2
-
-[OnFrame]
-# Add memory patches to be applied every frame here.
-
-[ActionReplay]
-# Add action replay cheats here.
-
-[Video_Hacks]
-ImmediateXFBEnable = False
diff --git a/Data/Sys/GameSettings/R3B.ini b/Data/Sys/GameSettings/R3B.ini
deleted file mode 100644
index e6567126cd..0000000000
--- a/Data/Sys/GameSettings/R3B.ini
+++ /dev/null
@@ -1,16 +0,0 @@
-# R3BE8P, R3BJ8P, R3BP8P - SambaDeAmigo
-
-[Core]
-# Values set here will override the main Dolphin settings.
-
-[OnFrame]
-# Add memory patches to be applied every frame here.
-
-[ActionReplay]
-# Add action replay cheats here.
-
-[Video_Settings]
-
-[Video_Hacks]
-ImmediateXFBEnable = False
-
diff --git a/Data/Sys/GameSettings/RBW.ini b/Data/Sys/GameSettings/RBW.ini
index a20b4c4c42..2335ce4f70 100644
--- a/Data/Sys/GameSettings/RBW.ini
+++ b/Data/Sys/GameSettings/RBW.ini
@@ -1,14 +1,4 @@
 # RBWE01, RBWJ01, RBWP01 - Battalion Wars 2
 
 [Core]
-# Values set here will override the main Dolphin settings.
 SyncOnSkipIdle = False
-
-[OnFrame]
-# Add memory patches to be applied every frame here.
-
-[ActionReplay]
-# Add action replay cheats here.
-
-[Video_Hacks]
-ImmediateXFBEnable = False
diff --git a/Data/Sys/GameSettings/RED.ini b/Data/Sys/GameSettings/RED.ini
deleted file mode 100644
index 58a7d70b38..0000000000
--- a/Data/Sys/GameSettings/RED.ini
+++ /dev/null
@@ -1,13 +0,0 @@
-# REDE41, REDJ41, REDP41 - RedSteel NTSC
-
-[Core]
-# Values set here will override the main Dolphin settings.
-
-[OnFrame]
-# Add memory patches to be applied every frame here.
-
-[ActionReplay]
-# Add action replay cheats here.
-
-[Video_Hacks]
-ImmediateXFBEnable = False
diff --git a/Data/Sys/GameSettings/RO7.ini b/Data/Sys/GameSettings/RO7.ini
index 9a68157835..1a8f2d6e12 100644
--- a/Data/Sys/GameSettings/RO7.ini
+++ b/Data/Sys/GameSettings/RO7.ini
@@ -1,18 +1,4 @@
 # RO7E7D, RO7P7D - The Legend of Spyro: The Eternal Night
 
-[Core]
-# Values set here will override the main Dolphin settings.
-
-[OnFrame]
-# Add memory patches to be applied every frame here.
-
-[ActionReplay]
-# Add action replay cheats here.
-
 [Video_Settings]
 SafeTextureCacheColorSamples = 512
-
-[Video_Hacks]
-ImmediateXFBEnable = False
-# Fixes missing splash logo at boot.
-EFBAccessEnable = True
diff --git a/Data/Sys/GameSettings/WTX.ini b/Data/Sys/GameSettings/WTX.ini
index 0e82b0b301..be0c6fabb3 100644
--- a/Data/Sys/GameSettings/WTX.ini
+++ b/Data/Sys/GameSettings/WTX.ini
@@ -1,16 +1,4 @@
 # WTXEJS, WTXPJS - Texas Hold'em Tournament
 
-[Core]
-# Values set here will override the main Dolphin settings.
-
-[OnFrame]
-# Add memory patches to be applied every frame here.
-
-[ActionReplay]
-# Add action replay cheats here.
-
 [Video_Settings]
 SuggestedAspectRatio = 2
-
-[Video_Hacks]
-ImmediateXFBEnable = False