Merge pull request #9144 from JosJuice/confirm-runnable-finish

Android: Remove finish from ConfirmRunnableViewHolder

2 files changed, 2 insertions, 3 deletions

diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsAdapter.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsAdapter.java
index 930d3d73a4..1c097ea06c 100644
--- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsAdapter.java
+++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsAdapter.java
@@ -331,6 +331,7 @@ public final class SettingsAdapter extends RecyclerView.Adapter<SettingViewHolde
     StringSetting.MAIN_RESOURCEPACK_PATH.delete(settings);
     StringSetting.MAIN_SD_PATH.delete(settings);
 
+    notifyItemRangeChanged(0, getItemCount());
     mView.onSettingChanged();
   }
 
@@ -344,6 +345,7 @@ public final class SettingsAdapter extends RecyclerView.Adapter<SettingViewHolde
               false).setBoolean(settings, value);
     }
 
+    notifyItemRangeChanged(0, getItemCount());
     mView.onSettingChanged();
   }
 
diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/viewholder/ConfirmRunnableViewHolder.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/viewholder/ConfirmRunnableViewHolder.java
index 401b0aadb2..2c73dd694a 100644
--- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/viewholder/ConfirmRunnableViewHolder.java
+++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/viewholder/ConfirmRunnableViewHolder.java
@@ -73,9 +73,6 @@ public final class ConfirmRunnableViewHolder extends SettingViewHolder
                 Toast.makeText(mContext, confirmationText, Toast.LENGTH_SHORT).show();
               }
               dialog.dismiss();
-
-              // TODO: Remove finish and properly update dynamic settings descriptions.
-              mView.getActivity().finish();
             })
             .setNegativeButton("No", (dialog, whichButton) ->
                     dialog.dismiss());