diff options
| author | JosJuice <josjuice@gmail.com> | 2019-06-17 15:31:20 +0200 |
|---|---|---|
| committer | JosJuice <josjuice@gmail.com> | 2019-07-02 19:27:42 +0200 |
| commit | 7652023407679cb5c9723ca006c1f88f847ae8db (patch) | |
| tree | a8d782ce916cd3f6d67255c672466d147f5ef505 /Source/Android/app/src/main/java | |
| parent | 0a7395bfba99719f71de5186a9916e66c1901f37 (diff) | |
Android: Don't copy global INIs into game INIs
See the source code comment in the next commit for why this is bad.
Diffstat (limited to 'Source/Android/app/src/main/java')
| -rw-r--r-- | Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/Settings.java | 18 |
1 files changed, 5 insertions, 13 deletions
diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/Settings.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/Settings.java index d76d9ec688..3eb9e1d2f7 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/Settings.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/Settings.java @@ -97,31 +97,23 @@ public class Settings { sections = new Settings.SettingsSectionMap(); - HashSet<String> filesToExclude = new HashSet<>(); - if (!TextUtils.isEmpty(gameId)) + if (TextUtils.isEmpty(gameId)) { - // for per-game settings, don't load the WiiMoteNew.ini settings - filesToExclude.add(SettingsFile.FILE_NAME_WIIMOTE); + loadDolphinSettings(view); } - - loadDolphinSettings(view, filesToExclude); - - if (!TextUtils.isEmpty(gameId)) + else { loadGenericGameSettings(gameId, view); loadCustomGameSettings(gameId, view); } } - private void loadDolphinSettings(SettingsActivityView view, HashSet<String> filesToExclude) + private void loadDolphinSettings(SettingsActivityView view) { for (Map.Entry<String, List<String>> entry : configFileSectionsMap.entrySet()) { String fileName = entry.getKey(); - if (filesToExclude == null || !filesToExclude.contains(fileName)) - { - sections.putAll(SettingsFile.readFile(fileName, view)); - } + sections.putAll(SettingsFile.readFile(fileName, view)); } } |
