diff options
| author | Ryan Houdek <Sonicadvance1@gmail.com> | 2014-06-02 17:57:23 -0500 |
|---|---|---|
| committer | Ryan Houdek <Sonicadvance1@gmail.com> | 2014-06-02 17:57:23 -0500 |
| commit | 7dc31fbd1a1c4f4a0015520fdbc693bdb66a5fed (patch) | |
| tree | a51612a9d87ccedcc3f068109ee997fe51f3d26e /Source/Android/src | |
| parent | 31eedb2f79318002a4772087f96eb034f94787a1 (diff) | |
Fix potential crash in Video Settings.
When Shaders folder didn't exist it would cause crash.
Diffstat (limited to 'Source/Android/src')
| -rw-r--r-- | Source/Android/src/org/dolphinemu/dolphinemu/settings/video/VideoSettingsFragment.java | 21 |
1 files changed, 13 insertions, 8 deletions
diff --git a/Source/Android/src/org/dolphinemu/dolphinemu/settings/video/VideoSettingsFragment.java b/Source/Android/src/org/dolphinemu/dolphinemu/settings/video/VideoSettingsFragment.java index e0ba5d3754..fe41335bd3 100644 --- a/Source/Android/src/org/dolphinemu/dolphinemu/settings/video/VideoSettingsFragment.java +++ b/Source/Android/src/org/dolphinemu/dolphinemu/settings/video/VideoSettingsFragment.java @@ -63,7 +63,7 @@ public final class VideoSettingsFragment extends PreferenceFragment // // Set available post processing shaders // - File[] shaders = new File(Environment.getExternalStorageDirectory()+ File.separator+"dolphin-emu"+ File.separator+"Shaders").listFiles(); + List<CharSequence> shader_names = new ArrayList<CharSequence>(); List<CharSequence> shader_values = new ArrayList<CharSequence>(); @@ -71,16 +71,21 @@ public final class VideoSettingsFragment extends PreferenceFragment shader_names.add("Disabled"); shader_values.add(""); - for (File file : shaders) + File shaders_folder = new File(Environment.getExternalStorageDirectory()+ File.separator+"dolphin-emu"+ File.separator+"Shaders"); + if (shaders_folder.exists()) { - if (file.isFile()) + File[] shaders = shaders_folder.listFiles(); + for (File file : shaders) { - String filename = file.getName(); - if (filename.contains(".glsl")) + if (file.isFile()) { - // Strip the extension and put it in to the list - shader_names.add(filename.substring(0, filename.lastIndexOf('.'))); - shader_values.add(filename.substring(0, filename.lastIndexOf('.'))); + String filename = file.getName(); + if (filename.contains(".glsl")) + { + // Strip the extension and put it in to the list + shader_names.add(filename.substring(0, filename.lastIndexOf('.'))); + shader_values.add(filename.substring(0, filename.lastIndexOf('.'))); + } } } } |
