diff options
| author | Lioncash <mathew1800@gmail.com> | 2013-08-30 15:31:25 -0400 |
|---|---|---|
| committer | Lioncash <mathew1800@gmail.com> | 2013-08-30 15:31:25 -0400 |
| commit | c633c2bb13fce4a99a025449af21d1b3f44cc19d (patch) | |
| tree | eab31c0d54386a0b2fe9a3535d102179d9254357 /Source/Android/src | |
| parent | 6428137ca4ab7934e6e22dc3b5497c5be347bc87 (diff) | |
[Android] Some various cleanups. Also make some class variables final.
Localize some variables as well, and clean up an import.
Diffstat (limited to 'Source/Android/src')
6 files changed, 6 insertions, 11 deletions
diff --git a/Source/Android/src/org/dolphinemu/dolphinemu/AboutFragment.java b/Source/Android/src/org/dolphinemu/dolphinemu/AboutFragment.java index 3a41b0872e..a94a22a964 100644 --- a/Source/Android/src/org/dolphinemu/dolphinemu/AboutFragment.java +++ b/Source/Android/src/org/dolphinemu/dolphinemu/AboutFragment.java @@ -28,14 +28,12 @@ import org.dolphinemu.dolphinemu.settings.VideoSettingsFragment; public final class AboutFragment extends Fragment { private static Activity m_activity; - private ListView mMainList; - private AboutFragmentAdapter adapter; @Override public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { View rootView = inflater.inflate(R.layout.gamelist_listview, container, false); - mMainList = (ListView) rootView.findViewById(R.id.gamelist); + ListView mMainList = (ListView) rootView.findViewById(R.id.gamelist); String yes = getString(R.string.yes); String no = getString(R.string.no); @@ -44,7 +42,7 @@ public final class AboutFragment extends Fragment Input.add(new AboutFragmentItem(getString(R.string.build_revision), NativeLibrary.GetVersionString())); Input.add(new AboutFragmentItem(getString(R.string.supports_gles3), VideoSettingsFragment.SupportsGLES3() ? yes : no)); - adapter = new AboutFragmentAdapter(m_activity, R.layout.about_layout, Input); + AboutFragmentAdapter adapter = new AboutFragmentAdapter(m_activity, R.layout.about_layout, Input); mMainList.setAdapter(adapter); return mMainList; diff --git a/Source/Android/src/org/dolphinemu/dolphinemu/EmulationActivity.java b/Source/Android/src/org/dolphinemu/dolphinemu/EmulationActivity.java index 7a81306468..71f896097c 100644 --- a/Source/Android/src/org/dolphinemu/dolphinemu/EmulationActivity.java +++ b/Source/Android/src/org/dolphinemu/dolphinemu/EmulationActivity.java @@ -11,7 +11,6 @@ import android.graphics.Color; import android.graphics.drawable.ColorDrawable; import android.os.Bundle; import android.util.DisplayMetrics; -import android.util.Log; import android.view.InputDevice; import android.view.KeyEvent; import android.view.Menu; diff --git a/Source/Android/src/org/dolphinemu/dolphinemu/folderbrowser/FolderBrowser.java b/Source/Android/src/org/dolphinemu/dolphinemu/folderbrowser/FolderBrowser.java index 306802a6de..890c43f347 100644 --- a/Source/Android/src/org/dolphinemu/dolphinemu/folderbrowser/FolderBrowser.java +++ b/Source/Android/src/org/dolphinemu/dolphinemu/folderbrowser/FolderBrowser.java @@ -112,7 +112,7 @@ public final class FolderBrowser extends Fragment return mDrawerList; } - private AdapterView.OnItemClickListener mMenuItemClickListener = new AdapterView.OnItemClickListener() + private final AdapterView.OnItemClickListener mMenuItemClickListener = new AdapterView.OnItemClickListener() { public void onItemClick(AdapterView<?> parent, View view, int position, long id) { @@ -143,7 +143,6 @@ public final class FolderBrowser extends Fragment { String Directories = NativeLibrary.GetConfig("Dolphin.ini", "General", "GCMPathes", "0"); int intDirectories = Integer.parseInt(Directories); - Directories = Integer.toString(intDirectories + 1); // Check to see if a path set in the Dolphin config // matches the one the user is trying to add. If it's diff --git a/Source/Android/src/org/dolphinemu/dolphinemu/gamelist/GameListActivity.java b/Source/Android/src/org/dolphinemu/dolphinemu/gamelist/GameListActivity.java index 86deafdeb6..5eaa24f9de 100644 --- a/Source/Android/src/org/dolphinemu/dolphinemu/gamelist/GameListActivity.java +++ b/Source/Android/src/org/dolphinemu/dolphinemu/gamelist/GameListActivity.java @@ -178,7 +178,7 @@ public final class GameListActivity extends Activity } } - private AdapterView.OnItemClickListener mMenuItemClickListener = new AdapterView.OnItemClickListener() + private final AdapterView.OnItemClickListener mMenuItemClickListener = new AdapterView.OnItemClickListener() { public void onItemClick(AdapterView<?> parent, View view, int position, long id) { diff --git a/Source/Android/src/org/dolphinemu/dolphinemu/gamelist/GameListFragment.java b/Source/Android/src/org/dolphinemu/dolphinemu/gamelist/GameListFragment.java index d5739d68ed..cdb5c2a745 100644 --- a/Source/Android/src/org/dolphinemu/dolphinemu/gamelist/GameListFragment.java +++ b/Source/Android/src/org/dolphinemu/dolphinemu/gamelist/GameListFragment.java @@ -120,7 +120,7 @@ public final class GameListFragment extends Fragment return mMainList; } - private AdapterView.OnItemClickListener mGameItemClickListener = new AdapterView.OnItemClickListener() + private final AdapterView.OnItemClickListener mGameItemClickListener = new AdapterView.OnItemClickListener() { public void onItemClick(AdapterView<?> parent, View view, int position, long id) { diff --git a/Source/Android/src/org/dolphinemu/dolphinemu/settings/InputConfigFragment.java b/Source/Android/src/org/dolphinemu/dolphinemu/settings/InputConfigFragment.java index 132db39ce0..985fb6d45e 100644 --- a/Source/Android/src/org/dolphinemu/dolphinemu/settings/InputConfigFragment.java +++ b/Source/Android/src/org/dolphinemu/dolphinemu/settings/InputConfigFragment.java @@ -30,11 +30,10 @@ import org.dolphinemu.dolphinemu.R; * within the input control mapping config. */ public final class InputConfigFragment extends PreferenceFragment - //implements PrefsActivity.OnGameConfigListener { private Activity m_activity; private boolean firstEvent = true; - private static ArrayList<Float> m_values = new ArrayList<Float>(); + private static final ArrayList<Float> m_values = new ArrayList<Float>(); /** * Gets the descriptor for the given {@link InputDevice}. |
