summaryrefslogtreecommitdiff
path: root/Source/Android
diff options
context:
space:
mode:
authorJosJuice <josjuice@gmail.com>2017-08-26 13:14:38 +0200
committerGitHub <noreply@github.com>2017-08-26 13:14:38 +0200
commit072b423de340f1c570ce64fd96a3928bf8a65357 (patch)
treeaba5cca6c8749285de1ee80e584ad2205d6f57b5 /Source/Android
parenta861c5772d3a36d55a7bef1dc7481f620460ff07 (diff)
parent5a361fd6b3b95e1688eeda0d18e0774e0106ad5d (diff)
Merge pull request #5967 from JonnyH/WIP/more-robust-android-settings-parser
Make the Android settings parser a bit more robust
Diffstat (limited to 'Source/Android')
-rw-r--r--Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/SettingsFile.java13
1 files changed, 11 insertions, 2 deletions
diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/SettingsFile.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/SettingsFile.java
index 205fffce6c..96f40c3296 100644
--- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/SettingsFile.java
+++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/SettingsFile.java
@@ -274,10 +274,13 @@ public final class SettingsFile
current = sectionFromLine(line);
sections.put(current.getName(), current);
}
- else if ((current != null) && line.contains("="))
+ else if ((current != null))
{
Setting setting = settingFromLine(current, line, fileName);
- current.putSetting(setting);
+ if (setting != null)
+ {
+ current.putSetting(setting);
+ }
}
}
}
@@ -381,6 +384,12 @@ public final class SettingsFile
{
String[] splitLine = line.split("=");
+ if (splitLine.length != 2)
+ {
+ Log.warning("Skipping invalid config line \"" + line + "\"");
+ return null;
+ }
+
String key = splitLine[0].trim();
String value = splitLine[1].trim();