diff options
| author | Lioncash <mathew1800@gmail.com> | 2019-05-31 07:03:52 -0400 |
|---|---|---|
| committer | Lioncash <mathew1800@gmail.com> | 2019-05-31 07:03:54 -0400 |
| commit | 15397e2a8909eb226e169d496852b6e5625fc4fb (patch) | |
| tree | 68478e504740656285b33f11f880c5dfb9f379c0 /Source/Core/AudioCommon/AudioCommon.cpp | |
| parent | 1a56e9d9e096db7e7f0e219776c3bbc8397cd296 (diff) | |
AudioCommon: Use emplace_back instead of push_back in GetSoundBackends()
Constructs the strings directly within the container instead of
performing a construction, then a copy.
The reasoning is that the BACKEND_* strings are const char arrays, so
the push_back code is equivalent to:
push_back(std::string(BACKEND_WHATEVER)) instead of forwarding the
arguments to a constructed instance directly in the container.
Diffstat (limited to 'Source/Core/AudioCommon/AudioCommon.cpp')
| -rw-r--r-- | Source/Core/AudioCommon/AudioCommon.cpp | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/Source/Core/AudioCommon/AudioCommon.cpp b/Source/Core/AudioCommon/AudioCommon.cpp index 79a89f83f9..ec68ef87aa 100644 --- a/Source/Core/AudioCommon/AudioCommon.cpp +++ b/Source/Core/AudioCommon/AudioCommon.cpp @@ -99,20 +99,20 @@ std::vector<std::string> GetSoundBackends() { std::vector<std::string> backends; - backends.push_back(BACKEND_NULLSOUND); - backends.push_back(BACKEND_CUBEB); + backends.emplace_back(BACKEND_NULLSOUND); + backends.emplace_back(BACKEND_CUBEB); if (XAudio2_7::isValid() || XAudio2::isValid()) - backends.push_back(BACKEND_XAUDIO2); + backends.emplace_back(BACKEND_XAUDIO2); if (AlsaSound::isValid()) - backends.push_back(BACKEND_ALSA); + backends.emplace_back(BACKEND_ALSA); if (PulseAudio::isValid()) - backends.push_back(BACKEND_PULSEAUDIO); + backends.emplace_back(BACKEND_PULSEAUDIO); if (OpenALStream::isValid()) - backends.push_back(BACKEND_OPENAL); + backends.emplace_back(BACKEND_OPENAL); if (OpenSLESStream::isValid()) - backends.push_back(BACKEND_OPENSLES); + backends.emplace_back(BACKEND_OPENSLES); if (WASAPIStream::isValid()) - backends.push_back(BACKEND_WASAPI); + backends.emplace_back(BACKEND_WASAPI); return backends; } |
