diff options
| author | Scott Mansell <phiren@gmail.com> | 2023-02-10 21:21:15 +1300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-10 21:21:15 +1300 |
| commit | dad7a32a35d0d28946c16e740692d014a858d2ea (patch) | |
| tree | 1422619a72cdcdf51e1d1e60509859f664d2d762 /Source/Core/Common/Debug/CodeTrace.cpp | |
| parent | a88e5ef3907e79ed20ab67e4df45c36e6ab2b909 (diff) | |
| parent | 3024ca2146cfdae2e7fb231e8d180dfc81e1a74e (diff) | |
Merge pull request #11534 from Pokechu22/warning-fixes-feb-2023
Resolve various compiler warnings
Diffstat (limited to 'Source/Core/Common/Debug/CodeTrace.cpp')
| -rw-r--r-- | Source/Core/Common/Debug/CodeTrace.cpp | 30 |
1 files changed, 15 insertions, 15 deletions
diff --git a/Source/Core/Common/Debug/CodeTrace.cpp b/Source/Core/Common/Debug/CodeTrace.cpp index 09939bdf96..65b7826770 100644 --- a/Source/Core/Common/Debug/CodeTrace.cpp +++ b/Source/Core/Common/Debug/CodeTrace.cpp @@ -48,6 +48,21 @@ u32 GetMemoryTargetSize(std::string_view instr) return 4; } + +bool CompareMemoryTargetToTracked(const std::string& instr, const u32 mem_target, + const std::set<u32>& mem_tracked) +{ + // This function is hit often and should be optimized. + auto it_lower = std::lower_bound(mem_tracked.begin(), mem_tracked.end(), mem_target); + + if (it_lower == mem_tracked.end()) + return false; + else if (*it_lower == mem_target) + return true; + + // If the base value doesn't hit, still need to check if longer values overlap. + return *it_lower < mem_target + GetMemoryTargetSize(instr); +} } // namespace void CodeTrace::SetRegTracked(const std::string& reg) @@ -124,21 +139,6 @@ TraceOutput CodeTrace::SaveCurrentInstruction() const return output; } -bool CompareMemoryTargetToTracked(const std::string& instr, const u32 mem_target, - const std::set<u32>& mem_tracked) -{ - // This function is hit often and should be optimized. - auto it_lower = std::lower_bound(mem_tracked.begin(), mem_tracked.end(), mem_target); - - if (it_lower == mem_tracked.end()) - return false; - else if (*it_lower == mem_target) - return true; - - // If the base value doesn't hit, still need to check if longer values overlap. - return *it_lower < mem_target + GetMemoryTargetSize(instr); -} - AutoStepResults CodeTrace::AutoStepping(bool continue_previous, AutoStop stop_on) { AutoStepResults results; |
