summaryrefslogtreecommitdiff
path: root/Source/Core/Common/HttpRequest.cpp
diff options
context:
space:
mode:
authorThomas May <wamwoowam@gmail.com>2020-10-27 11:05:53 +0000
committerLéo Lam <leo@leolam.fr>2020-10-29 21:20:59 +0100
commit72e1131123a1900815b9984396a720eae20fe9f0 (patch)
tree1be068589eaf297468f0d77d922a5b8e39c7fec7 /Source/Core/Common/HttpRequest.cpp
parentfe727ed1d095368229720da687f75f175065372d (diff)
Common: Fix logger related crash when HTTP response is empty
Diffstat (limited to 'Source/Core/Common/HttpRequest.cpp')
-rw-r--r--Source/Core/Common/HttpRequest.cpp12
1 files changed, 10 insertions, 2 deletions
diff --git a/Source/Core/Common/HttpRequest.cpp b/Source/Core/Common/HttpRequest.cpp
index 1cbf2aebc4..a60b33abbd 100644
--- a/Source/Core/Common/HttpRequest.cpp
+++ b/Source/Core/Common/HttpRequest.cpp
@@ -221,8 +221,16 @@ HttpRequest::Response HttpRequest::Impl::Fetch(const std::string& url, Method me
curl_easy_getinfo(m_curl.get(), CURLINFO_RESPONSE_CODE, &response_code);
if (response_code != 200)
{
- ERROR_LOG_FMT(COMMON, "Failed to {} {}: server replied with code {} and body\n\x1b[0m{:.{}}",
- type, url, response_code, buffer.data(), static_cast<int>(buffer.size()));
+ if (buffer.empty())
+ {
+ ERROR_LOG_FMT(COMMON, "Failed to {} {}: server replied with code {}", type, url,
+ response_code);
+ }
+ else
+ {
+ ERROR_LOG_FMT(COMMON, "Failed to {} {}: server replied with code {} and body\n\x1b[0m{:.{}}",
+ type, url, response_code, buffer.data(), static_cast<int>(buffer.size()));
+ }
return {};
}