diff options
| author | mathieui <mathieui@mathieui.net> | 2015-03-10 01:47:29 +0100 |
|---|---|---|
| committer | mathieui <mathieui@mathieui.net> | 2015-03-18 10:16:11 +0100 |
| commit | 8201a52cec975c6ed9c81bd6f33c41b3ef7b473a (patch) | |
| tree | 638729fa0539fbd0d6e622c1b9aa88ef4d71df6b /Source/Core/Common/TraversalClient.cpp | |
| parent | 849922881dbac56de584d079d65e14b2747df9af (diff) | |
Traversal: Use a decent PRNG instead of rand()
we don’t need cryptosecure random, but having a uniform distribution is
always better.
Diffstat (limited to 'Source/Core/Common/TraversalClient.cpp')
| -rw-r--r-- | Source/Core/Common/TraversalClient.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/Source/Core/Common/TraversalClient.cpp b/Source/Core/Common/TraversalClient.cpp index 02fe5ee26e..f17ce0d921 100644 --- a/Source/Core/Common/TraversalClient.cpp +++ b/Source/Core/Common/TraversalClient.cpp @@ -7,9 +7,10 @@ static void GetRandomishBytes(u8* buf, size_t size) { // We don't need high quality random numbers (which might not be available), // just non-repeating numbers! - srand(enet_time_get()); + static std::mt19937 prng(enet_time_get()); + static std::uniform_int_distribution<unsigned int> u8_distribution(0, 255); for (size_t i = 0; i < size; i++) - buf[i] = rand() & 0xff; + buf[i] = u8_distribution(prng); } TraversalClient::TraversalClient(ENetHost* netHost, const std::string& server, const u16 port) |