diff options
| author | Martino Fontana <tinozzo123@gmail.com> | 2026-04-06 11:37:26 +0200 |
|---|---|---|
| committer | Martino Fontana <tinozzo123@gmail.com> | 2026-04-17 12:39:46 +0200 |
| commit | 95dec132030e72b74da6bc46966e4fe5e4e239c0 (patch) | |
| tree | f4340655ebc036425e69048651ee49dec16ddc12 /Source/Core/Common/TraversalClient.cpp | |
| parent | 33f62b0f9f36a3dfccc3ecfc13358899d0cc8036 (diff) | |
Improve usage of std::move and const references parameters
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.
Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.
Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
Diffstat (limited to 'Source/Core/Common/TraversalClient.cpp')
| -rw-r--r-- | Source/Core/Common/TraversalClient.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/Source/Core/Common/TraversalClient.cpp b/Source/Core/Common/TraversalClient.cpp index 44b8390f90..2e0fb8e2ad 100644 --- a/Source/Core/Common/TraversalClient.cpp +++ b/Source/Core/Common/TraversalClient.cpp @@ -5,6 +5,7 @@ #include <cstddef> #include <cstring> #include <string> +#include <utility> #include "Common/CommonTypes.h" #include "Common/Logging/Log.h" @@ -14,9 +15,9 @@ namespace Common { -TraversalClient::TraversalClient(ENetHost* netHost, const std::string& server, const u16 port, +TraversalClient::TraversalClient(ENetHost* netHost, std::string server, const u16 port, const u16 port_alt) - : m_NetHost(netHost), m_Server(server), m_port(port), m_portAlt(port_alt) + : m_NetHost(netHost), m_Server(std::move(server)), m_port(port), m_portAlt(port_alt) { netHost->intercept = TraversalClient::InterceptCallback; |