diff options
| author | Martino Fontana <tinozzo123@gmail.com> | 2026-04-06 11:37:26 +0200 |
|---|---|---|
| committer | Martino Fontana <tinozzo123@gmail.com> | 2026-04-17 12:39:46 +0200 |
| commit | 95dec132030e72b74da6bc46966e4fe5e4e239c0 (patch) | |
| tree | f4340655ebc036425e69048651ee49dec16ddc12 /Source/Core/DolphinQt/Config/ConfigControls/ConfigChoice.cpp | |
| parent | 33f62b0f9f36a3dfccc3ecfc13358899d0cc8036 (diff) | |
Improve usage of std::move and const references parameters
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.
Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.
Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
Diffstat (limited to 'Source/Core/DolphinQt/Config/ConfigControls/ConfigChoice.cpp')
| -rw-r--r-- | Source/Core/DolphinQt/Config/ConfigControls/ConfigChoice.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Source/Core/DolphinQt/Config/ConfigControls/ConfigChoice.cpp b/Source/Core/DolphinQt/Config/ConfigControls/ConfigChoice.cpp index 60633b010f..d1027312d9 100644 --- a/Source/Core/DolphinQt/Config/ConfigControls/ConfigChoice.cpp +++ b/Source/Core/DolphinQt/Config/ConfigControls/ConfigChoice.cpp @@ -91,7 +91,7 @@ void ConfigStringChoice::OnConfigChanged() Load(); } -ConfigComplexChoice::ConfigComplexChoice(const InfoVariant setting1, const InfoVariant setting2, +ConfigComplexChoice::ConfigComplexChoice(const InfoVariant& setting1, const InfoVariant& setting2, Config::Layer* layer) : m_layer(layer), m_setting1(setting1), m_setting2(setting2) { |