diff options
| author | Lioncash <mathew1800@gmail.com> | 2019-07-31 09:16:01 -0400 |
|---|---|---|
| committer | Lioncash <mathew1800@gmail.com> | 2019-07-31 09:54:54 -0400 |
| commit | 6002529ece9aa9629169c56d30c3ba39ff98924a (patch) | |
| tree | 336d0fa2dffb30054fe3073480afa2ee154a5ab4 /Source/Core/DolphinQt/Config/GeckoCodeWidget.cpp | |
| parent | 255d2ff2d296307c562057c096a0d77c9c5e06b5 (diff) | |
DolphinQt/Config/GeckoCodeWidget: Make exec() outcomes explicit
Makes it a little more explicit which dialog outcomes we're expecting.
While we're at it, we can invert them into guard clauses to unindent
code a little bit.
Diffstat (limited to 'Source/Core/DolphinQt/Config/GeckoCodeWidget.cpp')
| -rw-r--r-- | Source/Core/DolphinQt/Config/GeckoCodeWidget.cpp | 22 |
1 files changed, 9 insertions, 13 deletions
diff --git a/Source/Core/DolphinQt/Config/GeckoCodeWidget.cpp b/Source/Core/DolphinQt/Config/GeckoCodeWidget.cpp index da015cf57b..6ed31fe0fd 100644 --- a/Source/Core/DolphinQt/Config/GeckoCodeWidget.cpp +++ b/Source/Core/DolphinQt/Config/GeckoCodeWidget.cpp @@ -185,33 +185,29 @@ void GeckoCodeWidget::AddCode() CheatCodeEditor ed(this); ed.SetGeckoCode(&code); + if (ed.exec() == QDialog::Rejected) + return; - if (ed.exec()) - { - m_gecko_codes.push_back(std::move(code)); - SaveCodes(); - UpdateList(); - } + m_gecko_codes.push_back(std::move(code)); + SaveCodes(); + UpdateList(); } void GeckoCodeWidget::EditCode() { const auto* item = m_code_list->currentItem(); - if (item == nullptr) return; const int index = item->data(Qt::UserRole).toInt(); CheatCodeEditor ed(this); - ed.SetGeckoCode(&m_gecko_codes[index]); + if (ed.exec() == QDialog::Rejected) + return; - if (ed.exec()) - { - SaveCodes(); - UpdateList(); - } + SaveCodes(); + UpdateList(); } void GeckoCodeWidget::RemoveCode() |
