DolphinQt: Fix spacebar not activating output mapping buttons.

1 files changed, 6 insertions, 8 deletions

diff --git a/Source/Core/DolphinQt/Config/Mapping/MappingButton.cpp b/Source/Core/DolphinQt/Config/Mapping/MappingButton.cpp
index a9a142276f..d472aa619f 100644
--- a/Source/Core/DolphinQt/Config/Mapping/MappingButton.cpp
+++ b/Source/Core/DolphinQt/Config/Mapping/MappingButton.cpp
@@ -56,7 +56,7 @@ MappingButton::MappingButton(MappingWidget* parent, ControlReference* ref, bool
   setToolTip(
       tr("Left-click to detect input.\nMiddle-click to clear.\nRight-click for more options."));
 
-  connect(this, &MappingButton::clicked, this, &MappingButton::Detect);
+  connect(this, &MappingButton::clicked, this, &MappingButton::Clicked);
 
   if (indicator)
     connect(parent, &MappingWidget::Update, this, &MappingButton::UpdateIndicator);
@@ -74,10 +74,13 @@ void MappingButton::AdvancedPressed()
   m_parent->SaveSettings();
 }
 
-void MappingButton::Detect()
+void MappingButton::Clicked()
 {
   if (!m_reference->IsInput())
+  {
+    AdvancedPressed();
     return;
+  }
 
   const auto default_device_qualifier = m_parent->GetController()->GetDefaultDevice();
 
@@ -141,12 +144,6 @@ void MappingButton::mouseReleaseEvent(QMouseEvent* event)
 {
   switch (event->button())
   {
-  case Qt::MouseButton::LeftButton:
-    if (m_reference->IsInput())
-      QPushButton::mouseReleaseEvent(event);
-    else
-      AdvancedPressed();
-    return;
   case Qt::MouseButton::MidButton:
     Clear();
     return;
@@ -154,6 +151,7 @@ void MappingButton::mouseReleaseEvent(QMouseEvent* event)
     AdvancedPressed();
     return;
   default:
+    QPushButton::mouseReleaseEvent(event);
     return;
   }
 }