summaryrefslogtreecommitdiff
path: root/Source/Core/DolphinQt/Config/Mapping/MappingButton.cpp
diff options
context:
space:
mode:
authorJordan Woyak <jordan.woyak@gmail.com>2025-01-22 13:22:33 -0600
committerGitHub <noreply@github.com>2025-01-22 13:22:33 -0600
commit4b4a58623b8475ab6f5ac11603d27bbf53f4356f (patch)
tree5258da97537a3bfbe31e5225c34e8a9aa8a5c916 /Source/Core/DolphinQt/Config/Mapping/MappingButton.cpp
parent76c613c8cd4cb9c0eab501da92156ede89fc3e89 (diff)
parentae72a781d40c33a55d3cf4965812d50129019f67 (diff)
Merge pull request #13283 from jordan-woyak/button-indicators
DolphinQt: Replace MappingButton bold text with graphical indicators.
Diffstat (limited to 'Source/Core/DolphinQt/Config/Mapping/MappingButton.cpp')
-rw-r--r--Source/Core/DolphinQt/Config/Mapping/MappingButton.cpp20
1 files changed, 1 insertions, 19 deletions
diff --git a/Source/Core/DolphinQt/Config/Mapping/MappingButton.cpp b/Source/Core/DolphinQt/Config/Mapping/MappingButton.cpp
index 794ed02997..3af4c2e00e 100644
--- a/Source/Core/DolphinQt/Config/Mapping/MappingButton.cpp
+++ b/Source/Core/DolphinQt/Config/Mapping/MappingButton.cpp
@@ -72,7 +72,7 @@ bool MappingButton::IsInput() const
return m_reference->IsInput();
}
-MappingButton::MappingButton(MappingWidget* parent, ControlReference* ref, bool indicator)
+MappingButton::MappingButton(MappingWidget* parent, ControlReference* ref)
: ElidedButton(RefToDisplayString(ref)), m_mapping_window(parent->GetParent()), m_reference(ref)
{
if (IsInput())
@@ -87,9 +87,6 @@ MappingButton::MappingButton(MappingWidget* parent, ControlReference* ref, bool
connect(this, &MappingButton::clicked, this, &MappingButton::Clicked);
- if (indicator)
- connect(parent, &MappingWidget::Update, this, &MappingButton::UpdateIndicator);
-
connect(parent, &MappingWidget::ConfigChanged, this, &MappingButton::ConfigChanged);
connect(this, &MappingButton::ConfigChanged, [this] {
setText(RefToDisplayString(m_reference));
@@ -134,21 +131,6 @@ void MappingButton::Clear()
m_mapping_window->UnQueueInputDetection(this);
}
-void MappingButton::UpdateIndicator()
-{
- QFont f = m_mapping_window->font();
-
- if (isActiveWindow() && m_reference->IsInput() && m_reference->GetState<bool>() && !m_is_mapping)
- f.setBold(true);
-
- // If the expression has failed to parse, show it in italic.
- // Some expressions still work even the failed to parse so don't prevent the GetState() above.
- if (m_reference->GetParseStatus() == ciface::ExpressionParser::ParseStatus::SyntaxError)
- f.setItalic(true);
-
- setFont(f);
-}
-
void MappingButton::StartMapping()
{
// Focus just makes it more clear which button is currently being mapped.