diff options
| author | Martino Fontana <tinozzo123@gmail.com> | 2026-04-06 11:37:26 +0200 |
|---|---|---|
| committer | Martino Fontana <tinozzo123@gmail.com> | 2026-04-17 12:39:46 +0200 |
| commit | 95dec132030e72b74da6bc46966e4fe5e4e239c0 (patch) | |
| tree | f4340655ebc036425e69048651ee49dec16ddc12 /Source/Core/DolphinQt/Config/VerifyWidget.cpp | |
| parent | 33f62b0f9f36a3dfccc3ecfc13358899d0cc8036 (diff) | |
Improve usage of std::move and const references parameters
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.
Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.
Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
Diffstat (limited to 'Source/Core/DolphinQt/Config/VerifyWidget.cpp')
| -rw-r--r-- | Source/Core/DolphinQt/Config/VerifyWidget.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/Source/Core/DolphinQt/Config/VerifyWidget.cpp b/Source/Core/DolphinQt/Config/VerifyWidget.cpp index b95a4ac269..b5814bb192 100644 --- a/Source/Core/DolphinQt/Config/VerifyWidget.cpp +++ b/Source/Core/DolphinQt/Config/VerifyWidget.cpp @@ -101,7 +101,8 @@ void VerifyWidget::CreateWidgets() m_verify_button = new QPushButton(tr("Verify Integrity"), this); } -std::pair<QCheckBox*, QLineEdit*> VerifyWidget::AddHashLine(QFormLayout* layout, QString text) +std::pair<QCheckBox*, QLineEdit*> VerifyWidget::AddHashLine(QFormLayout* layout, + const QString& text) { QLineEdit* line_edit = new QLineEdit(this); line_edit->setReadOnly(true); @@ -225,7 +226,7 @@ void VerifyWidget::Verify() m_redump_line_edit->setText(QString::fromStdString(result->redump.message)); } -void VerifyWidget::SetProblemCellText(int row, int column, QString text) +void VerifyWidget::SetProblemCellText(int row, int column, const QString& text) { QLabel* label = new QLabel(text); label->setTextInteractionFlags(Qt::TextSelectableByMouse); |