diff options
| author | Martino Fontana <tinozzo123@gmail.com> | 2026-04-06 11:37:26 +0200 |
|---|---|---|
| committer | Martino Fontana <tinozzo123@gmail.com> | 2026-04-17 12:39:46 +0200 |
| commit | 95dec132030e72b74da6bc46966e4fe5e4e239c0 (patch) | |
| tree | f4340655ebc036425e69048651ee49dec16ddc12 /Source/Core/DolphinQt/Debugger/AssemblyEditor.cpp | |
| parent | 33f62b0f9f36a3dfccc3ecfc13358899d0cc8036 (diff) | |
Improve usage of std::move and const references parameters
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.
Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.
Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
Diffstat (limited to 'Source/Core/DolphinQt/Debugger/AssemblyEditor.cpp')
| -rw-r--r-- | Source/Core/DolphinQt/Debugger/AssemblyEditor.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/Source/Core/DolphinQt/Debugger/AssemblyEditor.cpp b/Source/Core/DolphinQt/Debugger/AssemblyEditor.cpp index 4e74465bca..4d45513bc2 100644 --- a/Source/Core/DolphinQt/Debugger/AssemblyEditor.cpp +++ b/Source/Core/DolphinQt/Debugger/AssemblyEditor.cpp @@ -9,6 +9,7 @@ #include <QToolTip> #include <filesystem> +#include <utility> #include "Common/StringUtil.h" #include "DolphinQt/Debugger/GekkoSyntaxHighlight.h" @@ -23,8 +24,8 @@ void AsmEditor::LineNumberArea::paintEvent(QPaintEvent* event) asm_editor->LineNumberAreaPaintEvent(event); } -AsmEditor::AsmEditor(const QString& path, int editor_num, bool dark_scheme, QWidget* parent) - : QPlainTextEdit(parent), m_path(path), m_base_address(QStringLiteral("0")), +AsmEditor::AsmEditor(QString path, int editor_num, bool dark_scheme, QWidget* parent) + : QPlainTextEdit(parent), m_path(std::move(path)), m_base_address(QStringLiteral("0")), m_editor_num(editor_num), m_dirty(false), m_dark_scheme(dark_scheme) { if (!m_path.isEmpty()) |